You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by ptgoetz <gi...@git.apache.org> on 2016/06/06 18:26:39 UTC

[GitHub] storm issue #1468: STORM-1885. python script for squashing and merging prs.

Github user ptgoetz commented on the issue:

    https://github.com/apache/storm/pull/1468
  
    I'm a little on the fence in terms of squashing the commits of others vs. asking the contributor to do so. There are a lot of situations where spreading out a big patch over multiple commits makes sense and makes the history more consumable. 
    
    A couple of questions:
    * How does this preserve authorship in a pull request that has commits from multiple authors?
    * How would this work with our current branch model? Specifically, applying a pull request to multiple branches.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---