[GitHub] mbeckerle commented on a change in pull request #129: Cross Testing Capability with IBM DFDL

[GitBox <gi...@apache.org>]

mbeckerle commented on a change in pull request #129: Cross Testing Capability with IBM DFDL
URL: https://github.com/apache/incubator-daffodil/pull/129#discussion_r228673585
 
 

 ##########
 File path: daffodil-core/src/main/scala/org/apache/daffodil/compiler/Compiler.scala
 ##########
 @@ -302,7 +302,7 @@ class Compiler(var validateDFDLSchemas: Boolean = true)
    * to see if compilation was successful or not.
    */
   def compileFile(file: File): ProcessorFactory = {
-    val source = URISchemaSource(file.toURI)
+    val source = new URISchemaSource(file.toURI)
 
 Review comment:
   All these 'new' insertions could be reverted if an object with an apply method was created. That would really reduce the clutter. If you make the constructor protected, then these will all pop up in the compiler as illegal and can be fixed in bulk.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services