You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by Zoltan Farkas <zo...@yahoo.com.INVALID> on 2016/02/12 17:44:30 UTC
AVRO-1723 - can we implement this? patch is available, feature branch is available...
let me know
thank you
—Z
Re: AVRO-1723 - can we implement this? patch is available, feature
branch is available...
Posted by Ryan Blue <rb...@netflix.com.INVALID>.
Hi Zoltan, I just posted a review. I'd like you to take a look at some
changes to the patch I made, but overall the diagnosis and approach you
took is sound. Thanks for the fix!
rb
On Tue, Mar 1, 2016 at 9:53 AM, Zoltan Farkas <zo...@yahoo.com.invalid>
wrote:
> Can somebody look at this patch?
>
> thank you
>
> —Z
>
> > On Feb 18, 2016, at 11:04 PM, Zoltan Farkas <zo...@yahoo.com.INVALID>
> wrote:
> >
> > Hi Ryan,
> >
> > did you have a chance to look at the patch?
> >
> > thank you
> >
> > —Z
> >
> >
> >> On Feb 13, 2016, at 8:06 AM, Zoltan Farkas <zo...@yahoo.com.INVALID>
> wrote:
> >>
> >> Done, you have now a patch attached to the JIRA + a reference to a
> feature branch.
> >>
> >> let me know if you need anything else
> >>
> >> thank you
> >>
> >> —Z
> >>
> >>> On Feb 13, 2016, at 7:32 AM, Zoltan Farkas
> <zo...@yahoo.com.INVALID> wrote:
> >>>
> >>> Sure, will attach a path to AVRO-1667.
> >>>
> >>>
> >>> —Z
> >>>
> >>>
> >>>> On Feb 12, 2016, at 7:40 PM, Ryan Blue <rb...@netflix.com.INVALID>
> wrote:
> >>>>
> >>>> Hi Zoltan,
> >>>>
> >>>> I remember taking a look at this a couple months ago. I think we can
> get it
> >>>> in, but it isn't in a state where we can review it very easily
> because it
> >>>> mixes both AVRO-1667 <https://issues.apache.org/jira/browse/AVRO-1667>
> and
> >>>> AVRO-1723 <https://issues.apache.org/jira/browse/AVRO-1723>. Could
> you help
> >>>> us get AVRO-1667 <https://issues.apache.org/jira/browse/AVRO-1667>
> in first
> >>>> by putting together a clean patch with it?
> >>>>
> >>>> rb
> >>>>
> >>>> On Fri, Feb 12, 2016 at 8:44 AM, Zoltan Farkas
> <zolyfarkas@yahoo.com.invalid
> >>>>> wrote:
> >>>>
> >>>>> let me know
> >>>>>
> >>>>> thank you
> >>>>>
> >>>>> —Z
> >>>>
> >>>>
> >>>>
> >>>>
> >>>> --
> >>>> Ryan Blue
> >>>> Software Engineer
> >>>> Netflix
> >>>
> >>
> >
>
>
--
Ryan Blue
Software Engineer
Netflix
Re: AVRO-1723 - can we implement this? patch is available, feature branch is available...
Posted by Zoltan Farkas <zo...@yahoo.com.INVALID>.
Can somebody look at this patch?
thank you
—Z
> On Feb 18, 2016, at 11:04 PM, Zoltan Farkas <zo...@yahoo.com.INVALID> wrote:
>
> Hi Ryan,
>
> did you have a chance to look at the patch?
>
> thank you
>
> —Z
>
>
>> On Feb 13, 2016, at 8:06 AM, Zoltan Farkas <zo...@yahoo.com.INVALID> wrote:
>>
>> Done, you have now a patch attached to the JIRA + a reference to a feature branch.
>>
>> let me know if you need anything else
>>
>> thank you
>>
>> —Z
>>
>>> On Feb 13, 2016, at 7:32 AM, Zoltan Farkas <zo...@yahoo.com.INVALID> wrote:
>>>
>>> Sure, will attach a path to AVRO-1667.
>>>
>>>
>>> —Z
>>>
>>>
>>>> On Feb 12, 2016, at 7:40 PM, Ryan Blue <rb...@netflix.com.INVALID> wrote:
>>>>
>>>> Hi Zoltan,
>>>>
>>>> I remember taking a look at this a couple months ago. I think we can get it
>>>> in, but it isn't in a state where we can review it very easily because it
>>>> mixes both AVRO-1667 <https://issues.apache.org/jira/browse/AVRO-1667> and
>>>> AVRO-1723 <https://issues.apache.org/jira/browse/AVRO-1723>. Could you help
>>>> us get AVRO-1667 <https://issues.apache.org/jira/browse/AVRO-1667> in first
>>>> by putting together a clean patch with it?
>>>>
>>>> rb
>>>>
>>>> On Fri, Feb 12, 2016 at 8:44 AM, Zoltan Farkas <zolyfarkas@yahoo.com.invalid
>>>>> wrote:
>>>>
>>>>> let me know
>>>>>
>>>>> thank you
>>>>>
>>>>> —Z
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Ryan Blue
>>>> Software Engineer
>>>> Netflix
>>>
>>
>
Re: AVRO-1723 - can we implement this? patch is available, feature branch is available...
Posted by Zoltan Farkas <zo...@yahoo.com.INVALID>.
Hi Ryan,
did you have a chance to look at the patch?
thank you
—Z
> On Feb 13, 2016, at 8:06 AM, Zoltan Farkas <zo...@yahoo.com.INVALID> wrote:
>
> Done, you have now a patch attached to the JIRA + a reference to a feature branch.
>
> let me know if you need anything else
>
> thank you
>
> —Z
>
>> On Feb 13, 2016, at 7:32 AM, Zoltan Farkas <zo...@yahoo.com.INVALID> wrote:
>>
>> Sure, will attach a path to AVRO-1667.
>>
>>
>> —Z
>>
>>
>>> On Feb 12, 2016, at 7:40 PM, Ryan Blue <rb...@netflix.com.INVALID> wrote:
>>>
>>> Hi Zoltan,
>>>
>>> I remember taking a look at this a couple months ago. I think we can get it
>>> in, but it isn't in a state where we can review it very easily because it
>>> mixes both AVRO-1667 <https://issues.apache.org/jira/browse/AVRO-1667> and
>>> AVRO-1723 <https://issues.apache.org/jira/browse/AVRO-1723>. Could you help
>>> us get AVRO-1667 <https://issues.apache.org/jira/browse/AVRO-1667> in first
>>> by putting together a clean patch with it?
>>>
>>> rb
>>>
>>> On Fri, Feb 12, 2016 at 8:44 AM, Zoltan Farkas <zolyfarkas@yahoo.com.invalid
>>>> wrote:
>>>
>>>> let me know
>>>>
>>>> thank you
>>>>
>>>> —Z
>>>
>>>
>>>
>>>
>>> --
>>> Ryan Blue
>>> Software Engineer
>>> Netflix
>>
>
Re: AVRO-1723 - can we implement this? patch is available, feature branch is available...
Posted by Zoltan Farkas <zo...@yahoo.com.INVALID>.
Done, you have now a patch attached to the JIRA + a reference to a feature branch.
let me know if you need anything else
thank you
—Z
> On Feb 13, 2016, at 7:32 AM, Zoltan Farkas <zo...@yahoo.com.INVALID> wrote:
>
> Sure, will attach a path to AVRO-1667.
>
>
> —Z
>
>
>> On Feb 12, 2016, at 7:40 PM, Ryan Blue <rb...@netflix.com.INVALID> wrote:
>>
>> Hi Zoltan,
>>
>> I remember taking a look at this a couple months ago. I think we can get it
>> in, but it isn't in a state where we can review it very easily because it
>> mixes both AVRO-1667 <https://issues.apache.org/jira/browse/AVRO-1667> and
>> AVRO-1723 <https://issues.apache.org/jira/browse/AVRO-1723>. Could you help
>> us get AVRO-1667 <https://issues.apache.org/jira/browse/AVRO-1667> in first
>> by putting together a clean patch with it?
>>
>> rb
>>
>> On Fri, Feb 12, 2016 at 8:44 AM, Zoltan Farkas <zolyfarkas@yahoo.com.invalid
>>> wrote:
>>
>>> let me know
>>>
>>> thank you
>>>
>>> —Z
>>
>>
>>
>>
>> --
>> Ryan Blue
>> Software Engineer
>> Netflix
>
Re: AVRO-1723 - can we implement this? patch is available, feature branch is available...
Posted by Zoltan Farkas <zo...@yahoo.com.INVALID>.
Sure, will attach a path to AVRO-1667.
—Z
> On Feb 12, 2016, at 7:40 PM, Ryan Blue <rb...@netflix.com.INVALID> wrote:
>
> Hi Zoltan,
>
> I remember taking a look at this a couple months ago. I think we can get it
> in, but it isn't in a state where we can review it very easily because it
> mixes both AVRO-1667 <https://issues.apache.org/jira/browse/AVRO-1667> and
> AVRO-1723 <https://issues.apache.org/jira/browse/AVRO-1723>. Could you help
> us get AVRO-1667 <https://issues.apache.org/jira/browse/AVRO-1667> in first
> by putting together a clean patch with it?
>
> rb
>
> On Fri, Feb 12, 2016 at 8:44 AM, Zoltan Farkas <zolyfarkas@yahoo.com.invalid
>> wrote:
>
>> let me know
>>
>> thank you
>>
>> —Z
>
>
>
>
> --
> Ryan Blue
> Software Engineer
> Netflix
Re: AVRO-1723 - can we implement this? patch is available, feature
branch is available...
Posted by Ryan Blue <rb...@netflix.com.INVALID>.
Hi Zoltan,
I remember taking a look at this a couple months ago. I think we can get it
in, but it isn't in a state where we can review it very easily because it
mixes both AVRO-1667 <https://issues.apache.org/jira/browse/AVRO-1667> and
AVRO-1723 <https://issues.apache.org/jira/browse/AVRO-1723>. Could you help
us get AVRO-1667 <https://issues.apache.org/jira/browse/AVRO-1667> in first
by putting together a clean patch with it?
rb
On Fri, Feb 12, 2016 at 8:44 AM, Zoltan Farkas <zolyfarkas@yahoo.com.invalid
> wrote:
> let me know
>
> thank you
>
> —Z
--
Ryan Blue
Software Engineer
Netflix