You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/01 01:32:44 UTC

[GitHub] [yunikorn-k8shim] wusamzong opened a new pull request, #494: [YUNIKORN-1427] change to revive linter

wusamzong opened a new pull request, #494:
URL: https://github.com/apache/yunikorn-k8shim/pull/494

   ### What is this PR for?
   I follow the advise and update the configuration from `golint` to `revive`
   I am going to update on core and k8shim
   
   
   ### What type of PR is it?
   * [x] - Improvement
   
   ### What is the Jira issue?
   [https://issues.apache.org/jira/browse/YUNIKORN-1427](https://issues.apache.org/jira/browse/YUNIKORN-1427)
   
   ### How should this be tested?
   `make lint`
   
   ### Screenshots (if appropriate)
   Here is the result before update
   ![image](https://user-images.githubusercontent.com/48400525/204944267-15995935-235a-4d0c-a3b7-5327aea598e6.png)
   
   After update
   ![image](https://user-images.githubusercontent.com/48400525/204944190-4ff933f3-3634-4e65-bf95-35bca200e0f5.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #494: [YUNIKORN-1427] change to revive linter

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #494:
URL: https://github.com/apache/yunikorn-k8shim/pull/494#issuecomment-1333030113

   # [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/494?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#494](https://codecov.io/gh/apache/yunikorn-k8shim/pull/494?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b979dfb) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/94537d13beab34344c16a148d3a8241db127c11c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94537d1) will **increase** coverage by `0.37%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #494      +/-   ##
   ==========================================
   + Coverage   67.11%   67.49%   +0.37%     
   ==========================================
     Files          44       43       -1     
     Lines        7472     7460      -12     
   ==========================================
   + Hits         5015     5035      +20     
   + Misses       2268     2238      -30     
   + Partials      189      187       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/appmgmt/general/general.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/494/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwcG1nbXQvZ2VuZXJhbC9nZW5lcmFsLmdv) | `66.12% <100.00%> (ø)` | |
   | [pkg/cache/context.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/494/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `39.86% <100.00%> (ø)` | |
   | [pkg/common/utils/gang\_utils.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/494/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi91dGlscy9nYW5nX3V0aWxzLmdv) | `89.09% <100.00%> (+10.59%)` | :arrow_up: |
   | [pkg/common/utils/utils.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/494/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi91dGlscy91dGlscy5nbw==) | `74.21% <100.00%> (+10.31%)` | :arrow_up: |
   | [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/494/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `61.69% <100.00%> (-1.52%)` | :arrow_down: |
   | [pkg/common/utils/tg\_map.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/494/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi91dGlscy90Z19tYXAuZ28=) | | |
   | [pkg/common/si\_helper.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/494/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zaV9oZWxwZXIuZ28=) | `97.54% <0.00%> (+0.01%)` | :arrow_up: |
   | [pkg/cache/application.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/494/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `75.36% <0.00%> (+3.39%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [yunikorn-k8shim] wilfred-s closed pull request #494: [YUNIKORN-1427] change to revive linter

Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #494: [YUNIKORN-1427] change to revive linter
URL: https://github.com/apache/yunikorn-k8shim/pull/494


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org