[GitHub] [incubator-devlake] mintsweet commented on a diff in pull request #3717: feat(config-ui): gitlab project chooses to support the miller-columns component

[GitBox <gi...@apache.org>]

mintsweet commented on code in PR #3717:
URL: https://github.com/apache/incubator-devlake/pull/3717#discussion_r1019809224


##########
config-ui/src/components/miller-columns/hooks/use-miller-columns.ts:
##########
@@ -29,31 +29,49 @@ export interface UseMillerColumnsProps {
   items: ItemType[]
   activeItemId?: ItemType['id']
   onActiveItemId?: (id: ItemType['id']) => void
-  selectedItemIds?: Array<ItemType['id']>
+  selectedItemIds: Array<ItemType['id']>
   onSelectedItemIds?: (ids: Array<ItemType['id']>) => void
+  onExpandItem?: (item: ItemType) => void
 }
 
 export const useMillerColumns = ({
   items,
   onActiveItemId,
   onSelectedItemIds,
+  onExpandItem,
   ...props

Review Comment:
   This is a controlled component. The component itself has the props activeItemId. It is controlled by judging whether it is externally passed in.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org