[GitHub] flink pull request #5606: [FLINK-4387][QS] don't wait and process requests a...

[NicoK <gi...@git.apache.org>]

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/5606

    [FLINK-4387][QS] don't wait and process requests at Netty servers after shutdown request

    ## What is the purpose of the change
    
    There is a race condition on an assertion in Netty's event loop that may cause
    tests to fail when finished early.
    
    This was fixed in 4.0.33.Final via https://github.com/netty/netty/issues/4357 but we currently still rely on Netty 4.0.27.Final, hence the bug fix for the tests where this bug can be immanent.
    
    ## Brief change log
    
    - in QueryableState tests, do not wait for a "quiet period" for further events to arrive and process, this is not needed here and circumvents the bug
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
      - The S3 file system connector: **no**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **JavaDocs**


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-4387

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5606.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5606
    
----
commit 7acd43e9148da218806a43e2b381f84f8106d3ac
Author: Nico Kruber <ni...@...>
Date:   2018-03-01T08:43:56Z

    [FLINK-4387][QS] don't wait and process requests at Netty servers after shutdown request
    
    There is a race condition on an assertion in Netty's event loop that may cause
    tests to fail when finished early.
    
    This was fixed in 4.0.33.Final, see https://github.com/netty/netty/issues/4357.

----


---

[GitHub] flink pull request #5606: [FLINK-4387][QS][tests] don't wait and process req...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5606


---