You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/20 17:29:21 UTC

[GitHub] [pulsar] merlimat commented on a diff in pull request #15678: [improve][proxy] Support zero-copy of NIC to NIC on Proxy

merlimat commented on code in PR #15678:
URL: https://github.com/apache/pulsar/pull/15678#discussion_r878383154


##########
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/DirectProxyHandler.java:
##########
@@ -109,6 +112,10 @@ public void connect(String brokerHostAndPort, InetSocketAddress targetBrokerAddr
         b.group(inboundChannel.eventLoop())
                 .channel(inboundChannel.getClass());
 
+        if (service.zeroCopyModeEnabled) {
+            b.option(EpollChannelOption.EPOLL_MODE, EpollMode.LEVEL_TRIGGERED);

Review Comment:
   It should only be done if Epoll is supported and actually used on the channel



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org