[jira] [Updated] (HIVE-18279) Incorrect condition in StatsOpimizer

["Zoltan Haindrich (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-18279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zoltan Haindrich updated HIVE-18279:
------------------------------------
    Resolution: Invalid
        Status: Resolved  (was: Patch Available)

as my earlier comment...I don't think this is not an incorrect condition.
please submit a usecase which is producing incorrect results because of this

> Incorrect condition in StatsOpimizer
> ------------------------------------
>
>                 Key: HIVE-18279
>                 URL: https://issues.apache.org/jira/browse/HIVE-18279
>             Project: Hive
>          Issue Type: Bug
>          Components: Statistics
>            Reporter: Oleksiy Sayankin
>            Assignee: Oleksiy Sayankin
>            Priority: Major
>             Fix For: 3.2.0
>
>         Attachments: HIVE-18279.1.patch
>
>
> At the moment {{StatsOpimizer}} has code
> {code}
>         if (rowCnt == null) {
>           // if rowCnt < 1 than its either empty table or table on which stats are not
>           //  computed We assume the worse and don't attempt to optimize.
>           Logger.debug("Table doesn't have up to date stats " + tbl.getTableName());
>           rowCnt = null;
>         }
> {code}
> in method {{private Long getRowCnt()}}. Condition 
> {code}
> if (rowCnt == null) {
> {code}
> should be changed to 
> {code}
> if (rowCnt == null || rowCnt == 0) {
> {code}
> because 0 value also means that table stats may not be computed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)