You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2021/09/01 11:57:53 UTC

[GitHub] [libcloud] ckarageorgkaneen opened a new pull request #1599: Improve k8s drivers

ckarageorgkaneen opened a new pull request #1599:
URL: https://github.com/apache/libcloud/pull/1599


   - Improve and extend Kubernetes driver
   - Fix and extend GKE driver
   - Add EKS driver
   - Fix, improve, extend or add Kubernetes, GKE, EKS driver tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] codecov-commenter edited a comment on pull request #1599: Improve k8s drivers

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1599:
URL: https://github.com/apache/libcloud/pull/1599#issuecomment-910235940


   # [Codecov](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1599](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb899f1) into [trunk](https://codecov.io/gh/apache/libcloud/commit/ea364c58cd954d6b076c4e30bb283f33381a1246?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea364c5) will **increase** coverage by `0.01%`.
   > The diff coverage is `86.24%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/libcloud/pull/1599/graphs/tree.svg?width=650&height=150&src=pr&token=PYoduksh69&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##            trunk    #1599      +/-   ##
   ==========================================
   + Coverage   83.01%   83.02%   +0.01%     
   ==========================================
     Files         394      396       +2     
     Lines       84999    85414     +415     
     Branches     9040     9085      +45     
   ==========================================
   + Hits        70558    70915     +357     
   - Misses      11374    11415      +41     
   - Partials     3067     3084      +17     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [libcloud/container/providers.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL3Byb3ZpZGVycy5weQ==) | `66.66% <ø> (ø)` | |
   | [libcloud/utils/misc.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdXRpbHMvbWlzYy5weQ==) | `64.73% <19.56%> (-16.37%)` | :arrow_down: |
   | [libcloud/container/drivers/kubernetes.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL2RyaXZlcnMva3ViZXJuZXRlcy5weQ==) | `81.52% <84.53%> (+6.22%)` | :arrow_up: |
   | [libcloud/container/drivers/gke.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL2RyaXZlcnMvZ2tlLnB5) | `82.00% <89.36%> (+6.59%)` | :arrow_up: |
   | [libcloud/common/aws.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tbW9uL2F3cy5weQ==) | `86.23% <92.30%> (+1.40%)` | :arrow_up: |
   | [libcloud/container/drivers/eks.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL2RyaXZlcnMvZWtzLnB5) | `93.05% <93.05%> (ø)` | |
   | [libcloud/test/container/test\_eks.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb250YWluZXIvdGVzdF9la3MucHk=) | `97.72% <97.72%> (ø)` | |
   | [libcloud/common/base.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tbW9uL2Jhc2UucHk=) | `90.65% <100.00%> (+0.05%)` | :arrow_up: |
   | [libcloud/common/google.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tbW9uL2dvb2dsZS5weQ==) | `66.04% <100.00%> (+0.10%)` | :arrow_up: |
   | [libcloud/container/base.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL2Jhc2UucHk=) | `89.23% <100.00%> (+0.16%)` | :arrow_up: |
   | ... and [6 more](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ea364c5...fb899f1](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] Kami commented on pull request #1599: Improve k8s drivers

Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1599:
URL: https://github.com/apache/libcloud/pull/1599#issuecomment-1024687462


   @ckarageorgkaneen @d-mo I see the diff is quite large - are all the changes backward incompatible (I'm talking mostly about the changes to the common Google and AWS connection code).
   
   And how should we approach reviewing and merging this? Are the changes already ready for a review or are they still WIP?
   
   In ideal world, those changes would be split into multiple PRs, but I know that would mean more work on your side, re-organizing all those changes.
   
   So if we are confident about the tests coverage and all the changes being backward compatible, we can also try to review it in the current form :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] codecov-commenter edited a comment on pull request #1599: Improve k8s drivers

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1599:
URL: https://github.com/apache/libcloud/pull/1599#issuecomment-910235940


   # [Codecov](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1599](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (17be59e) into [trunk](https://codecov.io/gh/apache/libcloud/commit/ea364c58cd954d6b076c4e30bb283f33381a1246?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea364c5) will **increase** coverage by `0.00%`.
   > The diff coverage is `83.56%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/libcloud/pull/1599/graphs/tree.svg?width=650&height=150&src=pr&token=PYoduksh69&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff            @@
   ##            trunk    #1599    +/-   ##
   ========================================
     Coverage   83.01%   83.01%            
   ========================================
     Files         394      396     +2     
     Lines       84999    85423   +424     
     Branches     9040     9087    +47     
   ========================================
   + Hits        70558    70914   +356     
   - Misses      11374    11424    +50     
   - Partials     3067     3085    +18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [libcloud/container/providers.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL3Byb3ZpZGVycy5weQ==) | `66.66% <ø> (ø)` | |
   | [libcloud/utils/misc.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdXRpbHMvbWlzYy5weQ==) | `64.73% <19.56%> (-16.37%)` | :arrow_down: |
   | [libcloud/common/google.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tbW9uL2dvb2dsZS5weQ==) | `65.24% <37.50%> (-0.71%)` | :arrow_down: |
   | [libcloud/container/drivers/gke.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL2RyaXZlcnMvZ2tlLnB5) | `79.24% <83.01%> (+3.83%)` | :arrow_up: |
   | [libcloud/container/drivers/kubernetes.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL2RyaXZlcnMva3ViZXJuZXRlcy5weQ==) | `81.52% <84.53%> (+6.22%)` | :arrow_up: |
   | [libcloud/container/drivers/eks.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL2RyaXZlcnMvZWtzLnB5) | `90.66% <90.66%> (ø)` | |
   | [libcloud/common/aws.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tbW9uL2F3cy5weQ==) | `86.23% <92.30%> (+1.40%)` | :arrow_up: |
   | [libcloud/test/container/test\_eks.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb250YWluZXIvdGVzdF9la3MucHk=) | `97.72% <97.72%> (ø)` | |
   | [libcloud/common/base.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tbW9uL2Jhc2UucHk=) | `90.65% <100.00%> (+0.05%)` | :arrow_up: |
   | [libcloud/container/base.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL2Jhc2UucHk=) | `89.23% <100.00%> (+0.16%)` | :arrow_up: |
   | ... and [6 more](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ea364c5...17be59e](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] codecov-commenter edited a comment on pull request #1599: Improve k8s drivers

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1599:
URL: https://github.com/apache/libcloud/pull/1599#issuecomment-910235940


   # [Codecov](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1599](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cca8b76) into [trunk](https://codecov.io/gh/apache/libcloud/commit/ea364c58cd954d6b076c4e30bb283f33381a1246?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea364c5) will **increase** coverage by `0.01%`.
   > The diff coverage is `86.24%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/libcloud/pull/1599/graphs/tree.svg?width=650&height=150&src=pr&token=PYoduksh69&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##            trunk    #1599      +/-   ##
   ==========================================
   + Coverage   83.01%   83.02%   +0.01%     
   ==========================================
     Files         394      396       +2     
     Lines       84999    85414     +415     
     Branches     9040     9085      +45     
   ==========================================
   + Hits        70558    70915     +357     
   - Misses      11374    11415      +41     
   - Partials     3067     3084      +17     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [libcloud/container/providers.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL3Byb3ZpZGVycy5weQ==) | `66.66% <ø> (ø)` | |
   | [libcloud/utils/misc.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdXRpbHMvbWlzYy5weQ==) | `64.73% <19.56%> (-16.37%)` | :arrow_down: |
   | [libcloud/container/drivers/kubernetes.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL2RyaXZlcnMva3ViZXJuZXRlcy5weQ==) | `81.52% <84.53%> (+6.22%)` | :arrow_up: |
   | [libcloud/container/drivers/gke.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL2RyaXZlcnMvZ2tlLnB5) | `82.00% <89.36%> (+6.59%)` | :arrow_up: |
   | [libcloud/common/aws.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tbW9uL2F3cy5weQ==) | `86.23% <92.30%> (+1.40%)` | :arrow_up: |
   | [libcloud/container/drivers/eks.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL2RyaXZlcnMvZWtzLnB5) | `93.05% <93.05%> (ø)` | |
   | [libcloud/test/container/test\_eks.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb250YWluZXIvdGVzdF9la3MucHk=) | `97.72% <97.72%> (ø)` | |
   | [libcloud/common/base.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tbW9uL2Jhc2UucHk=) | `90.65% <100.00%> (+0.05%)` | :arrow_up: |
   | [libcloud/common/google.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tbW9uL2dvb2dsZS5weQ==) | `66.04% <100.00%> (+0.10%)` | :arrow_up: |
   | [libcloud/container/base.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL2Jhc2UucHk=) | `89.23% <100.00%> (+0.16%)` | :arrow_up: |
   | ... and [6 more](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ea364c5...cca8b76](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] codecov-commenter edited a comment on pull request #1599: Improve k8s drivers

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1599:
URL: https://github.com/apache/libcloud/pull/1599#issuecomment-910235940


   # [Codecov](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1599](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (57fea3b) into [trunk](https://codecov.io/gh/apache/libcloud/commit/ea364c58cd954d6b076c4e30bb283f33381a1246?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea364c5) will **increase** coverage by `0.01%`.
   > The diff coverage is `86.24%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/libcloud/pull/1599/graphs/tree.svg?width=650&height=150&src=pr&token=PYoduksh69&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##            trunk    #1599      +/-   ##
   ==========================================
   + Coverage   83.01%   83.02%   +0.01%     
   ==========================================
     Files         394      396       +2     
     Lines       84999    85414     +415     
     Branches     9040     9085      +45     
   ==========================================
   + Hits        70558    70915     +357     
   - Misses      11374    11415      +41     
   - Partials     3067     3084      +17     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [libcloud/container/providers.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL3Byb3ZpZGVycy5weQ==) | `66.66% <ø> (ø)` | |
   | [libcloud/utils/misc.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdXRpbHMvbWlzYy5weQ==) | `64.73% <19.56%> (-16.37%)` | :arrow_down: |
   | [libcloud/container/drivers/kubernetes.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL2RyaXZlcnMva3ViZXJuZXRlcy5weQ==) | `81.52% <84.53%> (+6.22%)` | :arrow_up: |
   | [libcloud/container/drivers/gke.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL2RyaXZlcnMvZ2tlLnB5) | `82.00% <89.36%> (+6.59%)` | :arrow_up: |
   | [libcloud/common/aws.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tbW9uL2F3cy5weQ==) | `86.23% <92.30%> (+1.40%)` | :arrow_up: |
   | [libcloud/container/drivers/eks.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL2RyaXZlcnMvZWtzLnB5) | `93.05% <93.05%> (ø)` | |
   | [libcloud/test/container/test\_eks.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb250YWluZXIvdGVzdF9la3MucHk=) | `97.72% <97.72%> (ø)` | |
   | [libcloud/common/base.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tbW9uL2Jhc2UucHk=) | `90.65% <100.00%> (+0.05%)` | :arrow_up: |
   | [libcloud/common/google.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tbW9uL2dvb2dsZS5weQ==) | `66.04% <100.00%> (+0.10%)` | :arrow_up: |
   | [libcloud/container/base.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL2Jhc2UucHk=) | `89.23% <100.00%> (+0.16%)` | :arrow_up: |
   | ... and [6 more](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ea364c5...57fea3b](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] d-mo commented on pull request #1599: Improve k8s drivers

Posted by GitBox <gi...@apache.org>.
d-mo commented on pull request #1599:
URL: https://github.com/apache/libcloud/pull/1599#issuecomment-1026050399


   Hi @Kami,
   
   Sure, we will split this up in a bunch smaller PR's, hopefully this week.
   @dimgal1 is currently working on it. Along with @ckarageorgkaneen they have extended the drivers further.
   
   Feel free to close this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] codecov-commenter commented on pull request #1599: Improve k8s drivers

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1599:
URL: https://github.com/apache/libcloud/pull/1599#issuecomment-910235940


   # [Codecov](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1599](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dbcb7db) into [trunk](https://codecov.io/gh/apache/libcloud/commit/ea364c58cd954d6b076c4e30bb283f33381a1246?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea364c5) will **increase** coverage by `0.01%`.
   > The diff coverage is `86.41%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/libcloud/pull/1599/graphs/tree.svg?width=650&height=150&src=pr&token=PYoduksh69&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##            trunk    #1599      +/-   ##
   ==========================================
   + Coverage   83.01%   83.02%   +0.01%     
   ==========================================
     Files         394      396       +2     
     Lines       84999    85413     +414     
     Branches     9040     9085      +45     
   ==========================================
   + Hits        70558    70915     +357     
   - Misses      11374    11414      +40     
   - Partials     3067     3084      +17     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [libcloud/container/providers.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL3Byb3ZpZGVycy5weQ==) | `66.66% <ø> (ø)` | |
   | [libcloud/utils/misc.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdXRpbHMvbWlzYy5weQ==) | `65.11% <20.00%> (-15.99%)` | :arrow_down: |
   | [libcloud/container/drivers/kubernetes.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL2RyaXZlcnMva3ViZXJuZXRlcy5weQ==) | `81.52% <84.53%> (+6.22%)` | :arrow_up: |
   | [libcloud/container/drivers/gke.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL2RyaXZlcnMvZ2tlLnB5) | `82.00% <89.36%> (+6.59%)` | :arrow_up: |
   | [libcloud/common/aws.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tbW9uL2F3cy5weQ==) | `86.23% <92.30%> (+1.40%)` | :arrow_up: |
   | [libcloud/container/drivers/eks.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL2RyaXZlcnMvZWtzLnB5) | `93.05% <93.05%> (ø)` | |
   | [libcloud/test/container/test\_eks.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb250YWluZXIvdGVzdF9la3MucHk=) | `97.72% <97.72%> (ø)` | |
   | [libcloud/common/base.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tbW9uL2Jhc2UucHk=) | `90.65% <100.00%> (+0.05%)` | :arrow_up: |
   | [libcloud/common/google.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tbW9uL2dvb2dsZS5weQ==) | `66.04% <100.00%> (+0.10%)` | :arrow_up: |
   | [libcloud/container/base.py](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29udGFpbmVyL2Jhc2UucHk=) | `89.23% <100.00%> (+0.16%)` | :arrow_up: |
   | ... and [6 more](https://codecov.io/gh/apache/libcloud/pull/1599/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ea364c5...dbcb7db](https://codecov.io/gh/apache/libcloud/pull/1599?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] Kami commented on pull request #1599: Improve k8s drivers

Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1599:
URL: https://github.com/apache/libcloud/pull/1599#issuecomment-1024688201


   And I assume this PR supersedes changes in https://github.com/apache/libcloud/pull/1423, so I can close that PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] Kami commented on pull request #1599: Improve k8s drivers

Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1599:
URL: https://github.com/apache/libcloud/pull/1599#issuecomment-1026202081


   @d-mo Great, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] Kami closed pull request #1599: Improve k8s drivers

Posted by GitBox <gi...@apache.org>.
Kami closed pull request #1599:
URL: https://github.com/apache/libcloud/pull/1599


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org