Issue with SHINDIG-1816

[Dan Dumont <dd...@apache.org>]

https://issues.apache.org/jira/browse/SHINDIG-1816

Since this patch, it appears that gadget-to-gadget communication is no
longer possible.  I believe that it's because of this change:

- return window.top.frames[siblingId.id];
+ return window.frames[siblingId.id];

When the gadgets go look up the target in the window, it's no longer
finding it in the window's frames (cause it needs to check the top window's
frames).
Would a search of window.parent up to window.top be sufficient to recover
from this issue and keep the fix for what you were trying to fix?

Re: Issue with SHINDIG-1816

[Henry Saputra <he...@gmail.com>]

Hi Dan,

Happy New Year to you.

Thanks for catching this. Sibling iframe should come from parent window =(
Super mea culpa from me.

Could you create a patch for this please?

Would be good reason to create new release.

- Henry



On Fri, Jan 4, 2013 at 6:16 AM, Dan Dumont <dd...@apache.org> wrote:

> https://issues.apache.org/jira/browse/SHINDIG-1816
>
> Since this patch, it appears that gadget-to-gadget communication is no
> longer possible.  I believe that it's because of this change:
>
> - return window.top.frames[siblingId.id];
> + return window.frames[siblingId.id];
>
> When the gadgets go look up the target in the window, it's no longer
> finding it in the window's frames (cause it needs to check the top window's
> frames).
> Would a search of window.parent up to window.top be sufficient to recover
> from this issue and keep the fix for what you were trying to fix?
>