[GitHub] [netbeans] junichi11 edited a comment on pull request #2524: Increase the major version for php.editor

[GitBox <gi...@apache.org>]

junichi11 edited a comment on pull request #2524:
URL: https://github.com/apache/netbeans/pull/2524#issuecomment-723012165


   @JaroslavTulach Thank you for your help.
   
   > Increasing major release version results in a change of module name to `OpenIDE-Module: org.netbeans.modules.php.editor/2` and it is the signal for the runtime container to reject any linkages that don't specify `/2`.
   
   Will do that. 
   
   > Specifying implementation version is only good if other (external) module use implementation dependency. It would be better to get rid of such implementation dependency in any case. Then you can remove the fixed `Implementation-Version` and it will be autogenerated to today's date, unless I am mistaken.
   
   Currently, `php.zend`, `php.zend2`, `php.symfony`, and some external plugins use implementation version. 
   External plugins may work fine no longer with the new version(nbms must be provided each NetBeans version) because they are not API friends of `php.editor`. (Just add them to  `php.editor` as API friends?)
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists