You are viewing a plain text version of this content. The canonical link for it is here.

Posted to log4php-dev@logging.apache.org by "Michal Vanek (JIRA)" <ji...@apache.org> on 2012/09/03 17:32:07 UTC

[jira] [Updated] (LOG4PHP-153) Merge LoggerAppenderEmail and LoggerAppenderEmailEvent into a single appender

     [ https://issues.apache.org/jira/browse/LOG4PHP-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michal Vanek updated LOG4PHP-153:
---------------------------------

    Attachment: phpunit-testresults.xml
                log4php.patch

Hi,

i have merged LoggerAppenderMail and LoggerAppenderMailEvent into LoggerAppenderMail

- bufferSize option added
  - 1 = old LoggerAppenderMailEvent behavior (every log event)
  - null = old LoggerAppenderMail behavior (on Close), unlimited buffering
  - other = Message is sent when bufferSize is reached

i have also tested it, seems to be ok.
                
> Merge LoggerAppenderEmail and LoggerAppenderEmailEvent into a single appender
> -----------------------------------------------------------------------------
>
>                 Key: LOG4PHP-153
>                 URL: https://issues.apache.org/jira/browse/LOG4PHP-153
>             Project: Log4php
>          Issue Type: Improvement
>          Components: Code
>    Affects Versions: 2.1.0
>            Reporter: Ivan Habunek
>            Assignee: Ivan Habunek
>            Priority: Minor
>              Labels: appender, email
>         Attachments: log4php.patch, phpunit-testresults.xml
>
>
> These two appenders are very similar. It would make sense to merge the functionality into a single logger which would have an option to buffer the output.
> For example, a "bufferSize" option can be added. If bufferSize is set to 10, then an email will be sent for every 10 logged messages. If bufferSize is set to 1, the appender will send an email for each logged message (like LoggerAppenderMailEvent) and if the bufferSize is set to NULL, then buffering would be unlimited (like LoggerAppenderMail).
> I propose to merge the whole funtionality into LoggerAppenderMail and make LoggerAppenderMailEvent deprecated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira