You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@continuum.apache.org by ct...@apache.org on 2010/01/08 06:48:54 UTC
svn commit: r897104 -
/continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
Author: ctan
Date: Fri Jan 8 05:48:47 2010
New Revision: 897104
URL: http://svn.apache.org/viewvc?rev=897104&view=rev
Log:
removed data directory during cleanup
Modified:
continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
Modified: continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
URL: http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml?rev=897104&r1=897103&r2=897104&view=diff
==============================================================================
--- continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml (original)
+++ continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml Fri Jan 8 05:48:47 2010
@@ -130,6 +130,17 @@
<build>
<plugins>
<plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-clean-plugin</artifactId>
+ <configuration>
+ <filesets>
+ <fileset>
+ <directory>${basedir}/data</directory>
+ </fileset>
+ </filesets>
+ </configuration>
+ </plugin>
+ <plugin>
<groupId>org.mortbay.jetty</groupId>
<artifactId>maven-jetty-plugin</artifactId>
<configuration>
Re: svn commit: r897104 - /continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
Posted by Brett Porter <br...@apache.org>.
Ok, so this is fine for now, but we should record an issue to get rid of the legacy stuff in a future release? plexus.home doesn't mean much any more :)
- Brett
On 11/01/2010, at 1:15 PM, Marica Tan wrote:
> The default is data/*.
>
> The DefaultConfigurationService checks whether the value of e.g.
> <workingDirectory> is an absolute path. If it isn't then it appends the
> applicationHome which defaults to ${plexus.home}.
>
>
> On Mon, Jan 11, 2010 at 9:12 AM, Brett Porter <br...@apache.org> wrote:
>
>>
>>
>> On 11/01/2010, at 11:37 AM, Marica Tan wrote:
>>
>>> See http://jira.codehaus.org/browse/CONTINUUM-1883
>>>
>>> Do we need to change it to target/appserver-base?
>>
>> I'm really not that familiar with how Continuum does it, but if you look at
>> the Archiva webapp POM you can see how the appserver-base directory is
>> managed. I was under the impression, due to the issue you pointed out, that
>> the default location for these directories was ${appserver.base}/data/* ?
>>
>> - Brett
>>
>>
>>>
>>> --
>>> Marica
>>>
>>> On Fri, Jan 8, 2010 at 2:54 PM, Brett Porter <br...@apache.org> wrote:
>>>
>>>> Why does it end up there? Do we need to better configure appserver-base
>>>> like in the other webapp?
>>>>
>>>> On 08/01/2010, at 4:48 PM, ctan@apache.org wrote:
>>>>
>>>>> Author: ctan
>>>>> Date: Fri Jan 8 05:48:47 2010
>>>>> New Revision: 897104
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=897104&view=rev
>>>>> Log:
>>>>> removed data directory during cleanup
>>>>>
>>>>> Modified:
>>>>>
>>>>
>> continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
>>>>>
>>>>> Modified:
>>>>
>> continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
>>>>> URL:
>>>>
>> http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml?rev=897104&r1=897103&r2=897104&view=diff
>>>>>
>>>>
>> ==============================================================================
>>>>> ---
>>>>
>> continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
>>>> (original)
>>>>> +++
>>>>
>> continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
>>>> Fri Jan 8 05:48:47 2010
>>>>> @@ -130,6 +130,17 @@
>>>>> <build>
>>>>> <plugins>
>>>>> <plugin>
>>>>> + <groupId>org.apache.maven.plugins</groupId>
>>>>> + <artifactId>maven-clean-plugin</artifactId>
>>>>> + <configuration>
>>>>> + <filesets>
>>>>> + <fileset>
>>>>> + <directory>${basedir}/data</directory>
>>>>> + </fileset>
>>>>> + </filesets>
>>>>> + </configuration>
>>>>> + </plugin>
>>>>> + <plugin>
>>>>> <groupId>org.mortbay.jetty</groupId>
>>>>> <artifactId>maven-jetty-plugin</artifactId>
>>>>> <configuration>
>>>>>
>>>>>
>>>>
>>>> --
>>>> Brett Porter
>>>> brett@apache.org
>>>> http://brettporter.wordpress.com/
>>>>
>>>>
>>>>
>>>>
>>>>
>>
>> --
>> Brett Porter
>> brett@apache.org
>> http://brettporter.wordpress.com/
>>
>>
>>
>>
>>
--
Brett Porter
brett@apache.org
http://brettporter.wordpress.com/
Re: svn commit: r897104 - /continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
Posted by Marica Tan <ma...@gmail.com>.
The default is data/*.
The DefaultConfigurationService checks whether the value of e.g.
<workingDirectory> is an absolute path. If it isn't then it appends the
applicationHome which defaults to ${plexus.home}.
On Mon, Jan 11, 2010 at 9:12 AM, Brett Porter <br...@apache.org> wrote:
>
>
> On 11/01/2010, at 11:37 AM, Marica Tan wrote:
>
> > See http://jira.codehaus.org/browse/CONTINUUM-1883
> >
> > Do we need to change it to target/appserver-base?
>
> I'm really not that familiar with how Continuum does it, but if you look at
> the Archiva webapp POM you can see how the appserver-base directory is
> managed. I was under the impression, due to the issue you pointed out, that
> the default location for these directories was ${appserver.base}/data/* ?
>
> - Brett
>
>
> >
> > --
> > Marica
> >
> > On Fri, Jan 8, 2010 at 2:54 PM, Brett Porter <br...@apache.org> wrote:
> >
> >> Why does it end up there? Do we need to better configure appserver-base
> >> like in the other webapp?
> >>
> >> On 08/01/2010, at 4:48 PM, ctan@apache.org wrote:
> >>
> >>> Author: ctan
> >>> Date: Fri Jan 8 05:48:47 2010
> >>> New Revision: 897104
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=897104&view=rev
> >>> Log:
> >>> removed data directory during cleanup
> >>>
> >>> Modified:
> >>>
> >>
> continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
> >>>
> >>> Modified:
> >>
> continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
> >>> URL:
> >>
> http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml?rev=897104&r1=897103&r2=897104&view=diff
> >>>
> >>
> ==============================================================================
> >>> ---
> >>
> continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
> >> (original)
> >>> +++
> >>
> continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
> >> Fri Jan 8 05:48:47 2010
> >>> @@ -130,6 +130,17 @@
> >>> <build>
> >>> <plugins>
> >>> <plugin>
> >>> + <groupId>org.apache.maven.plugins</groupId>
> >>> + <artifactId>maven-clean-plugin</artifactId>
> >>> + <configuration>
> >>> + <filesets>
> >>> + <fileset>
> >>> + <directory>${basedir}/data</directory>
> >>> + </fileset>
> >>> + </filesets>
> >>> + </configuration>
> >>> + </plugin>
> >>> + <plugin>
> >>> <groupId>org.mortbay.jetty</groupId>
> >>> <artifactId>maven-jetty-plugin</artifactId>
> >>> <configuration>
> >>>
> >>>
> >>
> >> --
> >> Brett Porter
> >> brett@apache.org
> >> http://brettporter.wordpress.com/
> >>
> >>
> >>
> >>
> >>
>
> --
> Brett Porter
> brett@apache.org
> http://brettporter.wordpress.com/
>
>
>
>
>
Re: svn commit: r897104 - /continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
Posted by Brett Porter <br...@apache.org>.
On 11/01/2010, at 11:37 AM, Marica Tan wrote:
> See http://jira.codehaus.org/browse/CONTINUUM-1883
>
> Do we need to change it to target/appserver-base?
I'm really not that familiar with how Continuum does it, but if you look at the Archiva webapp POM you can see how the appserver-base directory is managed. I was under the impression, due to the issue you pointed out, that the default location for these directories was ${appserver.base}/data/* ?
- Brett
>
> --
> Marica
>
> On Fri, Jan 8, 2010 at 2:54 PM, Brett Porter <br...@apache.org> wrote:
>
>> Why does it end up there? Do we need to better configure appserver-base
>> like in the other webapp?
>>
>> On 08/01/2010, at 4:48 PM, ctan@apache.org wrote:
>>
>>> Author: ctan
>>> Date: Fri Jan 8 05:48:47 2010
>>> New Revision: 897104
>>>
>>> URL: http://svn.apache.org/viewvc?rev=897104&view=rev
>>> Log:
>>> removed data directory during cleanup
>>>
>>> Modified:
>>>
>> continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
>>>
>>> Modified:
>> continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
>>> URL:
>> http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml?rev=897104&r1=897103&r2=897104&view=diff
>>>
>> ==============================================================================
>>> ---
>> continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
>> (original)
>>> +++
>> continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
>> Fri Jan 8 05:48:47 2010
>>> @@ -130,6 +130,17 @@
>>> <build>
>>> <plugins>
>>> <plugin>
>>> + <groupId>org.apache.maven.plugins</groupId>
>>> + <artifactId>maven-clean-plugin</artifactId>
>>> + <configuration>
>>> + <filesets>
>>> + <fileset>
>>> + <directory>${basedir}/data</directory>
>>> + </fileset>
>>> + </filesets>
>>> + </configuration>
>>> + </plugin>
>>> + <plugin>
>>> <groupId>org.mortbay.jetty</groupId>
>>> <artifactId>maven-jetty-plugin</artifactId>
>>> <configuration>
>>>
>>>
>>
>> --
>> Brett Porter
>> brett@apache.org
>> http://brettporter.wordpress.com/
>>
>>
>>
>>
>>
--
Brett Porter
brett@apache.org
http://brettporter.wordpress.com/
Re: svn commit: r897104 - /continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
Posted by Marica Tan <ma...@gmail.com>.
See http://jira.codehaus.org/browse/CONTINUUM-1883
Do we need to change it to target/appserver-base?
--
Marica
On Fri, Jan 8, 2010 at 2:54 PM, Brett Porter <br...@apache.org> wrote:
> Why does it end up there? Do we need to better configure appserver-base
> like in the other webapp?
>
> On 08/01/2010, at 4:48 PM, ctan@apache.org wrote:
>
> > Author: ctan
> > Date: Fri Jan 8 05:48:47 2010
> > New Revision: 897104
> >
> > URL: http://svn.apache.org/viewvc?rev=897104&view=rev
> > Log:
> > removed data directory during cleanup
> >
> > Modified:
> >
> continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
> >
> > Modified:
> continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
> > URL:
> http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml?rev=897104&r1=897103&r2=897104&view=diff
> >
> ==============================================================================
> > ---
> continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
> (original)
> > +++
> continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
> Fri Jan 8 05:48:47 2010
> > @@ -130,6 +130,17 @@
> > <build>
> > <plugins>
> > <plugin>
> > + <groupId>org.apache.maven.plugins</groupId>
> > + <artifactId>maven-clean-plugin</artifactId>
> > + <configuration>
> > + <filesets>
> > + <fileset>
> > + <directory>${basedir}/data</directory>
> > + </fileset>
> > + </filesets>
> > + </configuration>
> > + </plugin>
> > + <plugin>
> > <groupId>org.mortbay.jetty</groupId>
> > <artifactId>maven-jetty-plugin</artifactId>
> > <configuration>
> >
> >
>
> --
> Brett Porter
> brett@apache.org
> http://brettporter.wordpress.com/
>
>
>
>
>
Re: svn commit: r897104 - /continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
Posted by Brett Porter <br...@apache.org>.
Why does it end up there? Do we need to better configure appserver-base like in the other webapp?
On 08/01/2010, at 4:48 PM, ctan@apache.org wrote:
> Author: ctan
> Date: Fri Jan 8 05:48:47 2010
> New Revision: 897104
>
> URL: http://svn.apache.org/viewvc?rev=897104&view=rev
> Log:
> removed data directory during cleanup
>
> Modified:
> continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
>
> Modified: continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml
> URL: http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml?rev=897104&r1=897103&r2=897104&view=diff
> ==============================================================================
> --- continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml (original)
> +++ continuum/branches/continuum-1.3.x/continuum-buildagent/continuum-buildagent-webapp/pom.xml Fri Jan 8 05:48:47 2010
> @@ -130,6 +130,17 @@
> <build>
> <plugins>
> <plugin>
> + <groupId>org.apache.maven.plugins</groupId>
> + <artifactId>maven-clean-plugin</artifactId>
> + <configuration>
> + <filesets>
> + <fileset>
> + <directory>${basedir}/data</directory>
> + </fileset>
> + </filesets>
> + </configuration>
> + </plugin>
> + <plugin>
> <groupId>org.mortbay.jetty</groupId>
> <artifactId>maven-jetty-plugin</artifactId>
> <configuration>
>
>
--
Brett Porter
brett@apache.org
http://brettporter.wordpress.com/