[GitHub] [incubator-mxnet] ptrendx commented on a change in pull request #15688: Fix backward_clip num inputs and type of clip params

[GitBox <gi...@apache.org>]

ptrendx commented on a change in pull request #15688: Fix backward_clip num inputs and type of clip params
URL: https://github.com/apache/incubator-mxnet/pull/15688#discussion_r309358393
 
 

 ##########
 File path: src/operator/tensor/matrix_op.cc
 ##########
 @@ -763,7 +763,7 @@ parameter values:
 .add_arguments(ClipParam::__FIELDS__());
 
 NNVM_REGISTER_OP(_backward_clip)
-.set_num_inputs(1)
+.set_num_inputs(2)
 
 Review comment:
   I noticed it when trying to attach monitor to the executor which had clip - it failed with assertion about number of inputs mismatch.
   I am not aware of any other test that could uncover this - I don't think there are any checks for this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services