You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "vamossagar12 (via GitHub)" <gi...@apache.org> on 2023/10/18 08:34:24 UTC
[PR] KAFKA-15454: Add support for OffsetCommit version 9 in admin client [kafka]
vamossagar12 opened a new pull request, #14571:
URL: https://github.com/apache/kafka/pull/14571
This PR adds support for OffsetCommit version 9 in the admin client. It mainly allows handling 2 new error codes `STALE_MEMBER_EPOCH` and `UNKNOWN_TOPIC_ID` introduced as part of KIP-848.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15454: Add support for OffsetCommit version 9 in admin client [kafka]
Posted by "vamossagar12 (via GitHub)" <gi...@apache.org>.
vamossagar12 commented on code in PR #14571:
URL: https://github.com/apache/kafka/pull/14571#discussion_r1363747358
##########
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##########
@@ -4757,7 +4757,7 @@ public void testAlterConsumerGroupOffsetsNonRetriableErrors() throws Exception {
final TopicPartition tp1 = new TopicPartition("foo", 0);
final List<Errors> nonRetriableErrors = Arrays.asList(
- Errors.GROUP_AUTHORIZATION_FAILED, Errors.INVALID_GROUP_ID, Errors.GROUP_ID_NOT_FOUND);
+ Errors.GROUP_AUTHORIZATION_FAILED, Errors.INVALID_GROUP_ID, Errors.GROUP_ID_NOT_FOUND, Errors.STALE_MEMBER_EPOCH);
Review Comment:
`GROUP_ID_NOT_FOUND` was already part of this test. It was being handled in the default case but now gets handled directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15454: Add support for OffsetCommit version 9 in admin client [kafka]
Posted by "vamossagar12 (via GitHub)" <gi...@apache.org>.
vamossagar12 commented on PR #14571:
URL: https://github.com/apache/kafka/pull/14571#issuecomment-1768305023
Thanks David. Sorry, I looked at the KIP and not the response schema file. I have updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15454: Add support for OffsetCommit version 9 in admin client [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac merged PR #14571:
URL: https://github.com/apache/kafka/pull/14571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15454: Add support for OffsetCommit version 9 in admin client [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #14571:
URL: https://github.com/apache/kafka/pull/14571#issuecomment-1768286070
@vamossagar12 Thanks for the PR. We actually only added `GROUP_ID_NOT_FOUND` and `STALE_MEMBER_EPOCH` in [version 9](https://github.com/apache/kafka/blob/trunk/clients/src/main/resources/common/message/OffsetCommitResponse.json#L46) at the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org