[GitHub] [airflow] eladkal commented on a diff in pull request #24230: Fix backwards-compatibility introduced by fixing mypy problems

[GitBox <gi...@apache.org>]

eladkal commented on code in PR #24230:
URL: https://github.com/apache/airflow/pull/24230#discussion_r889715023


##########
scripts/ci/pre_commit/pre_commit_check_2_1_compatibility.py:
##########
@@ -91,6 +92,15 @@ def _check_file(_file: Path):
                 f"as it is not available in Airflow 2.2[/]"
             )
 
+        if GET_MANDATORY_MATCHER.match(line):
+            errors.append(
+                f"[red]In {_file}:{index} there is a forbidden construct "
+                f"(Airflow 2.3+ only):[/]\n\n"
+                f"{lines[index]}\n\n"
+                f"[yellow]You should not use conf.get_mandatory_value "
+                f"as it is not available in Airflow 2.2[/]"

Review Comment:
   Isn't the next provider release should set all providers to Airflow 2.2 as min version?
   https://github.com/apache/airflow#support-for-providers



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org