[GitHub] [hadoop] bgaborg commented on a change in pull request #1009: HADOOP-16383. Pass ITtlTimeProvider instance in initialize method in …

[GitBox <gi...@apache.org>]

bgaborg commented on a change in pull request #1009: HADOOP-16383. Pass ITtlTimeProvider instance in initialize method in …
URL: https://github.com/apache/hadoop/pull/1009#discussion_r299897790
 
 

 ##########
 File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java
 ##########
 @@ -377,11 +377,12 @@ private DynamoDB createDynamoDB(
    * FS via {@link S3AFileSystem#shareCredentials(String)}; this will
    * increment the reference counter of these credentials.
    * @param fs {@code S3AFileSystem} associated with the MetadataStore
+   * @param ttlTimeProvider
    * @throws IOException on a failure
    */
   @Override
   @Retries.OnceRaw
-  public void initialize(FileSystem fs) throws IOException {
+  public void initialize(FileSystem fs, ITtlTimeProvider ttlTimeProvider) throws IOException {
 
 Review comment:
   I think we should avoid that for now, and use it during another refactor maybe. I've fixed all the other stuff with my latest commit. Excluding this would change the whole point of this jira/pr

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org