You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/23 19:37:50 UTC
[GitHub] [arrow-rs] alamb opened a new pull request, #2147: Port Add stream upload (multi-part upload)
alamb opened a new pull request, #2147:
URL: https://github.com/apache/arrow-rs/pull/2147
# Which issue does this PR close?
Re https://github.com/apache/arrow-rs/issues/2030
# Rationale for this change
Multipart upload support was added to the object store in https://github.com/influxdata/object_store_rs/pull/20
by @wjones127 and @tustvold after the snapshot that was donated to the ASF in https://github.com/apache/arrow-rs/pull/2081.
# What changes are included in this PR?
Cherry-pick code from https://github.com/influxdata/object_store_rs/pull/20 to this repo
Specifically, what I did was
```shell
$ git fetch git@github.com:influxdata/object_store_rs.git
$ git checkout -b alamb/port-ulti-part-upload
$ git cherry-pick fe716c3
# manually resolved some conflicts
```
# Are there any user-facing changes?
mutli-part uploads!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #2147: Port Add stream upload (multi-part upload)
Posted by GitBox <gi...@apache.org>.
alamb merged PR #2147:
URL: https://github.com/apache/arrow-rs/pull/2147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #2147: Port Add stream upload (multi-part upload)
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2147:
URL: https://github.com/apache/arrow-rs/pull/2147#issuecomment-1194493241
I am hopeful once the action checks run on this repo this PR will be ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2147: Port Add stream upload (multi-part upload)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2147:
URL: https://github.com/apache/arrow-rs/pull/2147#issuecomment-1195550478
Benchmark runs are scheduled for baseline = aeb277642d1267673055aa0f705646db96dad340 and contender = 19fd8858991bcf8e654c221e6956ce6a8b5a86e1. 19fd8858991bcf8e654c221e6956ce6a8b5a86e1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9b8c2cd5e089415badb4444ebd70324b...2ad253bda6884d548de7a48986c60dc2/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a6064d5039e94740b946e4a59fc25b2f...95204bd8fcb84dc1aacb9eb9365051d8/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/ceb1de1f2e304d3e99713459ed0b0fca...89768b79218b4b178dfe1217caef98c3/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/43333a56ac244b38adb080d1f6625ded...f471d7dbcfa2406091bd89fefe7f348e/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #2147: Port Add stream upload (multi-part upload)
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2147:
URL: https://github.com/apache/arrow-rs/pull/2147#issuecomment-1194560843
@wjones127 and @tustvold this is now ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #2147: Port Add stream upload (multi-part upload)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2147:
URL: https://github.com/apache/arrow-rs/pull/2147#issuecomment-1193181616
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2147?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2147](https://codecov.io/gh/apache/arrow-rs/pull/2147?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7feab8d) into [master](https://codecov.io/gh/apache/arrow-rs/commit/19a71899d828f1c6204c97542645fd801a848ceb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (19a7189) will **decrease** coverage by `0.43%`.
> The diff coverage is `32.73%`.
```diff
@@ Coverage Diff @@
## master #2147 +/- ##
==========================================
- Coverage 82.86% 82.42% -0.44%
==========================================
Files 237 238 +1
Lines 61296 61830 +534
==========================================
+ Hits 50792 50966 +174
- Misses 10504 10864 +360
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/2147?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [object\_store/src/aws.rs](https://codecov.io/gh/apache/arrow-rs/pull/2147/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2JqZWN0X3N0b3JlL3NyYy9hd3MucnM=) | `0.00% <0.00%> (ø)` | |
| [object\_store/src/azure.rs](https://codecov.io/gh/apache/arrow-rs/pull/2147/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2JqZWN0X3N0b3JlL3NyYy9henVyZS5ycw==) | `0.00% <0.00%> (ø)` | |
| [object\_store/src/gcp.rs](https://codecov.io/gh/apache/arrow-rs/pull/2147/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2JqZWN0X3N0b3JlL3NyYy9nY3AucnM=) | `0.00% <0.00%> (ø)` | |
| [object\_store/src/multipart.rs](https://codecov.io/gh/apache/arrow-rs/pull/2147/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2JqZWN0X3N0b3JlL3NyYy9tdWx0aXBhcnQucnM=) | `0.00% <0.00%> (ø)` | |
| [object\_store/src/throttle.rs](https://codecov.io/gh/apache/arrow-rs/pull/2147/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2JqZWN0X3N0b3JlL3NyYy90aHJvdHRsZS5ycw==) | `94.63% <0.00%> (-1.89%)` | :arrow_down: |
| [object\_store/src/local.rs](https://codecov.io/gh/apache/arrow-rs/pull/2147/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2JqZWN0X3N0b3JlL3NyYy9sb2NhbC5ycw==) | `79.47% <72.78%> (-3.42%)` | :arrow_down: |
| [object\_store/src/memory.rs](https://codecov.io/gh/apache/arrow-rs/pull/2147/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2JqZWN0X3N0b3JlL3NyYy9tZW1vcnkucnM=) | `91.79% <85.00%> (-0.39%)` | :arrow_down: |
| [object\_store/src/lib.rs](https://codecov.io/gh/apache/arrow-rs/pull/2147/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2JqZWN0X3N0b3JlL3NyYy9saWIucnM=) | `86.75% <100.00%> (+2.33%)` | :arrow_up: |
| [...row/src/array/builder/string\_dictionary\_builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/2147/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIvc3RyaW5nX2RpY3Rpb25hcnlfYnVpbGRlci5ycw==) | `90.64% <0.00%> (-0.72%)` | :arrow_down: |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/2147/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.98% <0.00%> (+0.22%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/arrow-rs/pull/2147/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org