You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Alex Karasulu <ak...@apache.org> on 2007/05/26 16:48:20 UTC
Re: svn commit: r541888 - in /directory/daemon/trunk: bootstrappers/pom.xml plugin/pom.xml pom.xml
Hi Emmanuel,
I don't think you need to add a pluginManagement section to all leaf module
POMs.
If we add these pluginManagement sections to the root POMs of all
subprojects (see
below) then they get inherited by the leaf module POMs:
apacheds/pom.xml
daemon/pom.xml
shared/pom.xml
This way you can manage the plugin versions in one place. This was the main
reason
why the maven folks came up with pluginManagement sections. However if we
put a
pluginManagement section into every pom and replicate this information then
we're
foregoing the benefits we could gain by having one centralized
pluginManagement section
for each subproject.
Regards,
Alex
On 5/26/07, elecharny@apache.org <el...@apache.org> wrote:
>
> Author: elecharny
> Date: Sat May 26 05:31:15 2007
> New Revision: 541888
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=541888
> Log:
> Added some NL in bootstrapper/pom.xml for clarity
> Added a PluginManagement section in pom.xml, declaring all the used
> plugins
> Declared common configuration for the plugins in pom.xml
> Removed configuration from sub-poms
>
> Modified:
> directory/daemon/trunk/bootstrappers/pom.xml
> directory/daemon/trunk/plugin/pom.xml
> directory/daemon/trunk/pom.xml
>
> Modified: directory/daemon/trunk/bootstrappers/pom.xml
> URL:
> http://svn.apache.org/viewvc/directory/daemon/trunk/bootstrappers/pom.xml?view=diff&rev=541888&r1=541887&r2=541888
>
> ==============================================================================
> --- directory/daemon/trunk/bootstrappers/pom.xml (original)
> +++ directory/daemon/trunk/bootstrappers/pom.xml Sat May 26 05:31:15 2007
> @@ -9,10 +9,12 @@
> <artifactId>daemon-bootstrappers</artifactId>
> <name>Apache Directory Daemon Bootstrappers</name>
> <packaging>jar</packaging>
> +
> <description>
> Daemon bootstrappers which initialize a classloader with jars laid
> out in
> an installation footprint.
> </description>
> +
> <distributionManagement>
> <site>
> <id>apache.websites</id>
> @@ -21,6 +23,7 @@
> </url>
> </site>
> </distributionManagement>
> +
> <build>
> <plugins>
> <plugin>
>
> Modified: directory/daemon/trunk/plugin/pom.xml
> URL:
> http://svn.apache.org/viewvc/directory/daemon/trunk/plugin/pom.xml?view=diff&rev=541888&r1=541887&r2=541888
>
> ==============================================================================
> --- directory/daemon/trunk/plugin/pom.xml (original)
> +++ directory/daemon/trunk/plugin/pom.xml Sat May 26 05:31:15 2007
> @@ -9,36 +9,43 @@
> <artifactId>daemon-plugin</artifactId>
> <name>Apache Directory Daemon Plugin (Maven 2)</name>
> <packaging>maven-plugin</packaging>
> +
> <description>
> A plugin that builds installers using bootstrappers and
> commons-daemon procrun and jsvc
> </description>
> +
> <distributionManagement>
> <site>
> <id>apache.websites</id>
>
> <url>scp://minotaur.apache.org/www/directory.apache.org/newsite/subprojects/daemon/</url>
> </site>
> </distributionManagement>
> +
> <dependencies>
> <dependency>
> <groupId>${pom.groupId}</groupId>
> <artifactId>daemon-bootstrappers</artifactId>
> <version>${pom.version}</version>
> </dependency>
> +
> <dependency>
> <groupId>org.apache.maven</groupId>
> <artifactId>maven-plugin-api</artifactId>
> <version>2.0.1</version>
> </dependency>
> +
> <dependency>
> <groupId>org.apache.maven</groupId>
> <artifactId>maven-project</artifactId>
> <version>2.0</version>
> </dependency>
> +
> <dependency>
> <groupId>plexus</groupId>
> <artifactId>plexus-utils</artifactId>
> <version>1.0.2</version>
> </dependency>
> +
> <dependency>
> <groupId>izpack</groupId>
> <artifactId>standalone-compiler</artifactId>
> @@ -51,14 +58,9 @@
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> - <configuration>
> - <source>1.5</source>
> - <target>1.5</target>
> - </configuration>
> </plugin>
>
> </plugins>
> </build>
>
> </project>
> -
>
> Modified: directory/daemon/trunk/pom.xml
> URL:
> http://svn.apache.org/viewvc/directory/daemon/trunk/pom.xml?view=diff&rev=541888&r1=541887&r2=541888
>
> ==============================================================================
> --- directory/daemon/trunk/pom.xml (original)
> +++ directory/daemon/trunk/pom.xml Sat May 26 05:31:15 2007
> @@ -42,18 +42,53 @@
> </scm>
>
> <build>
> - <pluginManagement>
> + <pluginManagement>
> + <plugins>
> +
> + <plugin>
> + <groupId>org.apache.maven.plugins</groupId>
> + <artifactId>maven-surefire-plugin</artifactId>
> + <version>2.3</version>
> + </plugin>
> +
> + <plugin>
> + <groupId>org.apache.maven.plugins</groupId>
> + <artifactId>maven-jar-plugin</artifactId>
> + <version>2.1</version>
> + </plugin>
> +
> + <plugin>
> + <groupId>org.apache.maven.plugins</groupId>
> + <artifactId>maven-compiler-plugin</artifactId>
> + <version>2.0.2</version>
> + </plugin>
> +
> + </plugins>
> + </pluginManagement>
> +
> <plugins>
> +
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-surefire-plugin</artifactId>
> - <version>2.1.3</version>
> <configuration>
> <argLine>-Xmx1024m</argLine>
> </configuration>
> </plugin>
> +
> + <plugin>
> + <groupId>org.apache.maven.plugins</groupId>
> + <artifactId>maven-compiler-plugin</artifactId>
> + <configuration>
> + <source>1.5</source>
> + <target>1.5</target>
> + <optimize>true</optimize>
> + <showDeprecations>true</showDeprecations>
> + <encoding>ISO-8859-1</encoding>
> + </configuration>
> + </plugin>
> +
> </plugins>
> - </pluginManagement>
> </build>
> </project>
>
>
>
>
Re: svn commit: r541888 - in /directory/daemon/trunk: bootstrappers/pom.xml plugin/pom.xml pom.xml
Posted by Alex Karasulu <ak...@apache.org>.
OK I think I may be missunderstanding something. From your commit it seemed
to me
like you were adding a PM (pluginManagement) section to POMs like:
daemon/bootstrappers/pom.xml
daemon/plugin/pom.xml
(calling these poms leaf poms)
What I thought was that this stuff really belongs in one central place in
each subproject:
meaning in the root poms of the subprojects like daemon/pom.xml (calling
these poms
subproject root poms).
So are you putting PM sections into the subproject root poms or into the
leaf poms of
subproject modules?
Sorry about this confusion.
Alex
On 5/26/07, Emmanuel Lecharny <el...@apache.org> wrote:
>
> Alex Karasulu a écrit :
>
> > Hi Emmanuel,
> >
> > I don't think you need to add a pluginManagement section to all leaf
> > module
> > POMs.
>
> True. But I did intentionnaly : if shared is to be compiled as a
> standalone project, then the pluginManagement is already there. Now,
> what I'm not sure of is that we need to have a standalone shared (if so,
> this is good to simply dowload shared/* instead of downloading the full
> project : I was thinking about LS which only use shared)
>
> Another aspect is that I didn't want to introduce some error in daemon
> and apacheds while cleaning the dependencies, so I added those
> pluginManagement in sub-pom.
>
>
> But as soon as the dependencies are all cleaned, I will be able to
> remove the duplicated pluginManagement if needed.
>
> Emmanuel
>
Re: svn commit: r541888 - in /directory/daemon/trunk: bootstrappers/pom.xml
plugin/pom.xml pom.xml
Posted by Emmanuel Lecharny <el...@apache.org>.
Alex Karasulu a écrit :
> Hi Emmanuel,
>
> I don't think you need to add a pluginManagement section to all leaf
> module
> POMs.
True. But I did intentionnaly : if shared is to be compiled as a
standalone project, then the pluginManagement is already there. Now,
what I'm not sure of is that we need to have a standalone shared (if so,
this is good to simply dowload shared/* instead of downloading the full
project : I was thinking about LS which only use shared)
Another aspect is that I didn't want to introduce some error in daemon
and apacheds while cleaning the dependencies, so I added those
pluginManagement in sub-pom.
But as soon as the dependencies are all cleaned, I will be able to
remove the duplicated pluginManagement if needed.
Emmanuel