You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexander Simbirtsev (JIRA)" <ji...@apache.org> on 2006/12/12 16:05:21 UTC

[jira] Created: (HARMONY-2653) [classlib][swing] javax.swing.plaf.basic.BasicArrowButton doesn't use the 'highlight' parameter from the constructor when painting itself

[classlib][swing] javax.swing.plaf.basic.BasicArrowButton doesn't use the 'highlight' parameter from the constructor when painting itself
-----------------------------------------------------------------------------------------------------------------------------------------

                 Key: HARMONY-2653
                 URL: http://issues.apache.org/jira/browse/HARMONY-2653
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
            Reporter: Alexander Simbirtsev


There is no mention of any exception in the specification.
Harmony throws unspecified ClassCastException for getPreferredSize(new JFileChooser()) while RI throws unspecified NPE.

Use the following code to reproduce:

import javax.swing.JFileChooser;
import javax.swing.plaf.basic.BasicListUI;

import junit.framework.TestCase;

public class Test extends TestCase {
    public void testcase1() {
        try {                     
            BasicListUI bl = new BasicListUI();
            bl.getPreferredSize(new JFileChooser() );               
        } catch (NullPointerException e) {   
            //expected
        } catch (ClassCastException e) {
            fail("No NPE thrown");
        }
    }
}


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2653) [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException

Posted by "Alexander Simbirtsev (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478419 ] 

Alexander Simbirtsev commented on HARMONY-2653:
-----------------------------------------------

Verified. Works fine.

> [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2653
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2653
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexander Simbirtsev
>         Assigned To: Alexey Petrenko
>         Attachments: BasicListUI-patch.txt, H2653-BasicListUITest.patch, H2653-BasicListUITest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony throws unspecified ClassCastException for getPreferredSize(new JFileChooser()) while RI throws unspecified NPE.
> Use the following code to reproduce:
> import javax.swing.JFileChooser;
> import javax.swing.plaf.basic.BasicListUI;
> import junit.framework.TestCase;
> public class Test extends TestCase {
>     public void testcase1() {
>         try {                     
>             BasicListUI bl = new BasicListUI();
>             bl.getPreferredSize(new JFileChooser() );               
>         } catch (NullPointerException e) {   
>             //expected
>         } catch (ClassCastException e) {
>             fail("No NPE thrown");
>         }
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-2653) [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException

Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Petrenko resolved HARMONY-2653.
--------------------------------------

    Resolution: Fixed

The patch has been applied.
Please verify.

> [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2653
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2653
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexander Simbirtsev
>         Assigned To: Alexey Petrenko
>         Attachments: BasicListUI-patch.txt, H2653-BasicListUITest.patch, H2653-BasicListUITest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony throws unspecified ClassCastException for getPreferredSize(new JFileChooser()) while RI throws unspecified NPE.
> Use the following code to reproduce:
> import javax.swing.JFileChooser;
> import javax.swing.plaf.basic.BasicListUI;
> import junit.framework.TestCase;
> public class Test extends TestCase {
>     public void testcase1() {
>         try {                     
>             BasicListUI bl = new BasicListUI();
>             bl.getPreferredSize(new JFileChooser() );               
>         } catch (NullPointerException e) {   
>             //expected
>         } catch (ClassCastException e) {
>             fail("No NPE thrown");
>         }
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-2653) [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465102 ] 

Mark Hindess commented on HARMONY-2653:
---------------------------------------

I was thinking of something like:

public void testcase1() throws ClassCastException {
    try {
        BasicListUI bl = new BasicListUI();
        bl.getPreferredSize(new JFileChooser() );
        fail("No NPE thrown"); // This would be pass in your version??
    } catch (NullPointerException e) {
        //expected
    }
}

The main advantage of letting junit handle the ClassCastException is that you get the full stack trace and IMHO it's easier to read.

> [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2653
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2653
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexander Simbirtsev
>         Attachments: BasicListUI-patch.txt, H2653-BasicListUITest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony throws unspecified ClassCastException for getPreferredSize(new JFileChooser()) while RI throws unspecified NPE.
> Use the following code to reproduce:
> import javax.swing.JFileChooser;
> import javax.swing.plaf.basic.BasicListUI;
> import junit.framework.TestCase;
> public class Test extends TestCase {
>     public void testcase1() {
>         try {                     
>             BasicListUI bl = new BasicListUI();
>             bl.getPreferredSize(new JFileChooser() );               
>         } catch (NullPointerException e) {   
>             //expected
>         } catch (ClassCastException e) {
>             fail("No NPE thrown");
>         }
>     }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2653) [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException

Posted by "Alexander Simbirtsev (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2653?page=all ]

Alexander Simbirtsev updated HARMONY-2653:
------------------------------------------

    Attachment: BasicListUI-patch.txt

Here's the proposed fix

> [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2653
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2653
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexander Simbirtsev
>         Attachments: BasicListUI-patch.txt
>
>
> There is no mention of any exception in the specification.
> Harmony throws unspecified ClassCastException for getPreferredSize(new JFileChooser()) while RI throws unspecified NPE.
> Use the following code to reproduce:
> import javax.swing.JFileChooser;
> import javax.swing.plaf.basic.BasicListUI;
> import junit.framework.TestCase;
> public class Test extends TestCase {
>     public void testcase1() {
>         try {                     
>             BasicListUI bl = new BasicListUI();
>             bl.getPreferredSize(new JFileChooser() );               
>         } catch (NullPointerException e) {   
>             //expected
>         } catch (ClassCastException e) {
>             fail("No NPE thrown");
>         }
>     }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2653) [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464546 ] 

Mark Hindess commented on HARMONY-2653:
---------------------------------------

Dmitry,

Any reason why we should have a fail after the line:

  bl.getPreferredSize(new JFileChooser() ); 

the test seems incomplete without it?  Can we let junit handle the ClassCastException?


> [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2653
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2653
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexander Simbirtsev
>         Attachments: BasicListUI-patch.txt, H2653-BasicListUITest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony throws unspecified ClassCastException for getPreferredSize(new JFileChooser()) while RI throws unspecified NPE.
> Use the following code to reproduce:
> import javax.swing.JFileChooser;
> import javax.swing.plaf.basic.BasicListUI;
> import junit.framework.TestCase;
> public class Test extends TestCase {
>     public void testcase1() {
>         try {                     
>             BasicListUI bl = new BasicListUI();
>             bl.getPreferredSize(new JFileChooser() );               
>         } catch (NullPointerException e) {   
>             //expected
>         } catch (ClassCastException e) {
>             fail("No NPE thrown");
>         }
>     }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2653) [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464538 ] 

Mark Hindess commented on HARMONY-2653:
---------------------------------------

I get a stack overflow running this test (with or without the fix).


> [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2653
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2653
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexander Simbirtsev
>         Attachments: BasicListUI-patch.txt, H2653-BasicListUITest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony throws unspecified ClassCastException for getPreferredSize(new JFileChooser()) while RI throws unspecified NPE.
> Use the following code to reproduce:
> import javax.swing.JFileChooser;
> import javax.swing.plaf.basic.BasicListUI;
> import junit.framework.TestCase;
> public class Test extends TestCase {
>     public void testcase1() {
>         try {                     
>             BasicListUI bl = new BasicListUI();
>             bl.getPreferredSize(new JFileChooser() );               
>         } catch (NullPointerException e) {   
>             //expected
>         } catch (ClassCastException e) {
>             fail("No NPE thrown");
>         }
>     }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2653) [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException

Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464860 ] 

Dmitry Irlyanov commented on HARMONY-2653:
------------------------------------------

Mark,
I've added the catching of ClassCastException to differentiate the expected regression with possible other errors (fail and error). i.e. if the regression test fails - there is a regression, otherwise - a error and the other possible reason.
Anyway, the test will be good without additional catching :)

> [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2653
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2653
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexander Simbirtsev
>         Attachments: BasicListUI-patch.txt, H2653-BasicListUITest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony throws unspecified ClassCastException for getPreferredSize(new JFileChooser()) while RI throws unspecified NPE.
> Use the following code to reproduce:
> import javax.swing.JFileChooser;
> import javax.swing.plaf.basic.BasicListUI;
> import junit.framework.TestCase;
> public class Test extends TestCase {
>     public void testcase1() {
>         try {                     
>             BasicListUI bl = new BasicListUI();
>             bl.getPreferredSize(new JFileChooser() );               
>         } catch (NullPointerException e) {   
>             //expected
>         } catch (ClassCastException e) {
>             fail("No NPE thrown");
>         }
>     }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (HARMONY-2653) [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException

Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Petrenko reassigned HARMONY-2653:
----------------------------------------

    Assignee: Alexey Petrenko

> [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2653
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2653
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexander Simbirtsev
>         Assigned To: Alexey Petrenko
>         Attachments: BasicListUI-patch.txt, H2653-BasicListUITest.patch, H2653-BasicListUITest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony throws unspecified ClassCastException for getPreferredSize(new JFileChooser()) while RI throws unspecified NPE.
> Use the following code to reproduce:
> import javax.swing.JFileChooser;
> import javax.swing.plaf.basic.BasicListUI;
> import junit.framework.TestCase;
> public class Test extends TestCase {
>     public void testcase1() {
>         try {                     
>             BasicListUI bl = new BasicListUI();
>             bl.getPreferredSize(new JFileChooser() );               
>         } catch (NullPointerException e) {   
>             //expected
>         } catch (ClassCastException e) {
>             fail("No NPE thrown");
>         }
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-2653) [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException

Posted by "Alexander Simbirtsev (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2653?page=all ]

Alexander Simbirtsev updated HARMONY-2653:
------------------------------------------

    Summary: [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException  (was: [classlib][swing] javax.swing.plaf.basic.BasicArrowButton doesn't use the 'highlight' parameter from the constructor when painting itself)

> [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2653
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2653
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexander Simbirtsev
>
> There is no mention of any exception in the specification.
> Harmony throws unspecified ClassCastException for getPreferredSize(new JFileChooser()) while RI throws unspecified NPE.
> Use the following code to reproduce:
> import javax.swing.JFileChooser;
> import javax.swing.plaf.basic.BasicListUI;
> import junit.framework.TestCase;
> public class Test extends TestCase {
>     public void testcase1() {
>         try {                     
>             BasicListUI bl = new BasicListUI();
>             bl.getPreferredSize(new JFileChooser() );               
>         } catch (NullPointerException e) {   
>             //expected
>         } catch (ClassCastException e) {
>             fail("No NPE thrown");
>         }
>     }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2653) [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException

Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465512 ] 

Dmitry Irlyanov commented on HARMONY-2653:
------------------------------------------

Not at all :) I've just saying that without additional catching regression test is incorrect. 
My patch is incorrect - you said because (it passes if no exception throws). I've corrected the regression test 

I think it is unavailing discussion. I've started it due to ironic comment, my apologies.

> [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2653
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2653
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexander Simbirtsev
>         Attachments: BasicListUI-patch.txt, H2653-BasicListUITest.patch, H2653-BasicListUITest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony throws unspecified ClassCastException for getPreferredSize(new JFileChooser()) while RI throws unspecified NPE.
> Use the following code to reproduce:
> import javax.swing.JFileChooser;
> import javax.swing.plaf.basic.BasicListUI;
> import junit.framework.TestCase;
> public class Test extends TestCase {
>     public void testcase1() {
>         try {                     
>             BasicListUI bl = new BasicListUI();
>             bl.getPreferredSize(new JFileChooser() );               
>         } catch (NullPointerException e) {   
>             //expected
>         } catch (ClassCastException e) {
>             fail("No NPE thrown");
>         }
>     }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2653) [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException

Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465131 ] 

Dmitry Irlyanov commented on HARMONY-2653:
------------------------------------------

Mark, the regression test test in your comment is incorrect - it's describes the case if no NullPointerException throws.
But the issue is ClassCastException instead of NullPointer. 
Stack trace is useful for failure evaluation - i. e. the test code is investigated and JIRA issue is found.
Any other exceptions will be processed by junit. 

> [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2653
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2653
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexander Simbirtsev
>         Attachments: BasicListUI-patch.txt, H2653-BasicListUITest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony throws unspecified ClassCastException for getPreferredSize(new JFileChooser()) while RI throws unspecified NPE.
> Use the following code to reproduce:
> import javax.swing.JFileChooser;
> import javax.swing.plaf.basic.BasicListUI;
> import junit.framework.TestCase;
> public class Test extends TestCase {
>     public void testcase1() {
>         try {                     
>             BasicListUI bl = new BasicListUI();
>             bl.getPreferredSize(new JFileChooser() );               
>         } catch (NullPointerException e) {   
>             //expected
>         } catch (ClassCastException e) {
>             fail("No NPE thrown");
>         }
>     }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (HARMONY-2653) [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException

Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Petrenko closed HARMONY-2653.
------------------------------------


> [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2653
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2653
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexander Simbirtsev
>         Assigned To: Alexey Petrenko
>         Attachments: BasicListUI-patch.txt, H2653-BasicListUITest.patch, H2653-BasicListUITest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony throws unspecified ClassCastException for getPreferredSize(new JFileChooser()) while RI throws unspecified NPE.
> Use the following code to reproduce:
> import javax.swing.JFileChooser;
> import javax.swing.plaf.basic.BasicListUI;
> import junit.framework.TestCase;
> public class Test extends TestCase {
>     public void testcase1() {
>         try {                     
>             BasicListUI bl = new BasicListUI();
>             bl.getPreferredSize(new JFileChooser() );               
>         } catch (NullPointerException e) {   
>             //expected
>         } catch (ClassCastException e) {
>             fail("No NPE thrown");
>         }
>     }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-2653) [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Hindess updated HARMONY-2653:
----------------------------------

    Comment: was deleted

> [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2653
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2653
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexander Simbirtsev
>         Attachments: BasicListUI-patch.txt, H2653-BasicListUITest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony throws unspecified ClassCastException for getPreferredSize(new JFileChooser()) while RI throws unspecified NPE.
> Use the following code to reproduce:
> import javax.swing.JFileChooser;
> import javax.swing.plaf.basic.BasicListUI;
> import junit.framework.TestCase;
> public class Test extends TestCase {
>     public void testcase1() {
>         try {                     
>             BasicListUI bl = new BasicListUI();
>             bl.getPreferredSize(new JFileChooser() );               
>         } catch (NullPointerException e) {   
>             //expected
>         } catch (ClassCastException e) {
>             fail("No NPE thrown");
>         }
>     }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2653) [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException

Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2653?page=all ]

Dmitry Irlyanov updated HARMONY-2653:
-------------------------------------

    Attachment: H2653-BasicListUITest.patch

Regression test addition

> [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2653
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2653
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexander Simbirtsev
>         Attachments: BasicListUI-patch.txt, H2653-BasicListUITest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony throws unspecified ClassCastException for getPreferredSize(new JFileChooser()) while RI throws unspecified NPE.
> Use the following code to reproduce:
> import javax.swing.JFileChooser;
> import javax.swing.plaf.basic.BasicListUI;
> import junit.framework.TestCase;
> public class Test extends TestCase {
>     public void testcase1() {
>         try {                     
>             BasicListUI bl = new BasicListUI();
>             bl.getPreferredSize(new JFileChooser() );               
>         } catch (NullPointerException e) {   
>             //expected
>         } catch (ClassCastException e) {
>             fail("No NPE thrown");
>         }
>     }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2653) [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException

Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitry Irlyanov updated HARMONY-2653:
-------------------------------------

    Attachment: H2653-BasicListUITest.patch

> [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2653
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2653
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexander Simbirtsev
>         Attachments: BasicListUI-patch.txt, H2653-BasicListUITest.patch, H2653-BasicListUITest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony throws unspecified ClassCastException for getPreferredSize(new JFileChooser()) while RI throws unspecified NPE.
> Use the following code to reproduce:
> import javax.swing.JFileChooser;
> import javax.swing.plaf.basic.BasicListUI;
> import junit.framework.TestCase;
> public class Test extends TestCase {
>     public void testcase1() {
>         try {                     
>             BasicListUI bl = new BasicListUI();
>             bl.getPreferredSize(new JFileChooser() );               
>         } catch (NullPointerException e) {   
>             //expected
>         } catch (ClassCastException e) {
>             fail("No NPE thrown");
>         }
>     }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2653) [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465136 ] 

Mark Hindess commented on HARMONY-2653:
---------------------------------------

So to be clear,  you are saying that the fail I placed before the first catch isn't required because an implementation would be correct even if it didn't throw the expected NullPointerException?

To me it appears that if the RI throws a NPE then we *must* and not throwing it should be a failure.



> [classlib][swing] javax.swing.plaf.basic.BasicListUI.getPreferredSize(new JFileChooser() ) throws unspecified ClassCastException
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2653
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2653
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexander Simbirtsev
>         Attachments: BasicListUI-patch.txt, H2653-BasicListUITest.patch
>
>
> There is no mention of any exception in the specification.
> Harmony throws unspecified ClassCastException for getPreferredSize(new JFileChooser()) while RI throws unspecified NPE.
> Use the following code to reproduce:
> import javax.swing.JFileChooser;
> import javax.swing.plaf.basic.BasicListUI;
> import junit.framework.TestCase;
> public class Test extends TestCase {
>     public void testcase1() {
>         try {                     
>             BasicListUI bl = new BasicListUI();
>             bl.getPreferredSize(new JFileChooser() );               
>         } catch (NullPointerException e) {   
>             //expected
>         } catch (ClassCastException e) {
>             fail("No NPE thrown");
>         }
>     }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira