You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/06 14:40:27 UTC

[GitHub] [druid] abossert opened a new issue #9322: Kafka Indexing Service consumer properties not respected

abossert opened a new issue #9322: Kafka Indexing Service consumer properties not respected
URL: https://github.com/apache/druid/issues/9322
 
 
   I used the unified console to create a Kafka Indexing supervisor and have been adding custom configurations in the consumer properties that include the bootstrap servers and a custom deserializer, which has worked flawlessly until I added another property (auto.offset.reset).  When I look at the resulting log files, I see that the auto.offset.reset property is, in fact in my ingestSpec, but is not passed on to the Kafka consumer properties.  My setting is 'earliest' and the consumer properties shows 'none'.
   
   I have inspected org.apache.druid.indexing.kafka.KafkaConsumerConfigs and found that the probably culprit is that 'auto.offset.reset' is hard-coded.  Perhaps the simplest fix might be to remove the hard-coded setting here, but maybe I am missing something:
   
   ```java
   /*
    * Licensed to the Apache Software Foundation (ASF) under one
    * or more contributor license agreements.  See the NOTICE file
    * distributed with this work for additional information
    * regarding copyright ownership.  The ASF licenses this file
    * to you under the Apache License, Version 2.0 (the
    * "License"); you may not use this file except in compliance
    * with the License.  You may obtain a copy of the License at
    *
    *   http://www.apache.org/licenses/LICENSE-2.0
    *
    * Unless required by applicable law or agreed to in writing,
    * software distributed under the License is distributed on an
    * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    * KIND, either express or implied.  See the License for the
    * specific language governing permissions and limitations
    * under the License.
    */
   
   package org.apache.druid.indexing.kafka;
   
   import org.apache.druid.indexing.common.task.utils.RandomIdUtils;
   import org.apache.druid.java.util.common.StringUtils;
   
   import java.util.HashMap;
   import java.util.Map;
   
   /**
    * Common place to keep all kafka consumer configs
    */
   public class KafkaConsumerConfigs
   {
   
     public static Map<String, Object> getConsumerProperties()
     {
       final Map<String, Object> props = new HashMap<>();
       props.put("metadata.max.age.ms", "10000");
       props.put("group.id", StringUtils.format("kafka-supervisor-%s", RandomIdUtils.getRandomId()));
       props.put("auto.offset.reset", "none");
       props.put("enable.auto.commit", "false");
       props.put("isolation.level", "read_committed");
       return props;
     }
   
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] jihoonson commented on issue #9322: Kafka Indexing Service consumer properties not respected

Posted by GitBox <gi...@apache.org>.
jihoonson commented on issue #9322: Kafka Indexing Service consumer properties not respected
URL: https://github.com/apache/druid/issues/9322#issuecomment-583048861
 
 
   Hi @abossert, I believe it is hard-coded by design. The Kafka indexing service is designed to guarantee the exactly-once ingestion which requires Druid to track valid offsets of partitions. If some offsets are expired and automatically reset in Kafka, Druid will find some gaps between the offsets from Kafka and the ones it is aware of, which will lead to an internal error. If you want to reset automatically with the Kafka indexing service, please consider setting `resetOffsetAutomatically` and `useEarliestOffset` properly in the tuningConfig. Also, please note that resetting automatically will lead to DATA LOSS (when `useEarliestOffset = false) or DATA DUPLICATION (when `useEarliestOffset = true).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org