You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/05/17 17:00:13 UTC
Review Request 59343: Add a process ID for RemoteProcess in the
libprocess tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59343/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-7401
https://issues.apache.org/jira/browse/MESOS-7401
Repository: mesos
Description
-------
Add a process ID for RemoteProcess in the libprocess tests so that we
generate a process UPID containing a valid IP address.
Diffs
-----
3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115
Diff: https://reviews.apache.org/r/59343/diff/1/
Testing
-------
make check (Fedora 25)
Thanks,
James Peach
Re: Review Request 59343: Add a process ID for RemoteProcess in the
libprocess tests.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59343/#review176345
-----------------------------------------------------------
Ship it!
Hm.. I'm not sure why you're saying this is needed to generate a UPID with valid IP address? This seems to just be a debugging improvement (e.g. see which processes are running).
- Benjamin Mahler
On May 17, 2017, 5 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59343/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 5 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7401
> https://issues.apache.org/jira/browse/MESOS-7401
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add a process ID for RemoteProcess in the libprocess tests so that we
> generate a process UPID containing a valid IP address.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115
>
>
> Diff: https://reviews.apache.org/r/59343/diff/2/
>
>
> Testing
> -------
>
> make check (Fedora 25)
>
>
> Thanks,
>
> James Peach
>
>