[GitHub] [spark] srowen commented on a change in pull request #24302: [SPARK-27392][SQL] TestHive test tables should be placed in shared test state, not per session

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #24302: [SPARK-27392][SQL] TestHive test tables should be placed in shared test state, not per session
URL: https://github.com/apache/spark/pull/24302#discussion_r272691871
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/QueryExecutionMetering.scala
 ##########
 @@ -64,10 +64,13 @@ case class QueryExecutionMetering() {
   /** Dump statistics about time spent running specific rules. */
   def dumpTimeSpent(): String = {
     val map = timeMap.asMap().asScala
-    val maxLengthRuleNames = if (map.isEmpty) {
-      0
-    } else {
-      map.keys.map(_.toString.length).max
+    val maxLengthRuleNames = {
 
 Review comment:
   Did this fix anything? Looks like equivalent logic and would be ever so slightly slower

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org