[GitHub] [druid] gianm commented on a change in pull request #10233: Add "offset" parameter to the Scan query.

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #10233:
URL: https://github.com/apache/druid/pull/10233#discussion_r469551515



##########
File path: processing/src/main/java/org/apache/druid/query/scan/ScanQuery.java
##########
@@ -202,12 +210,38 @@ public int getBatchSize()
     return batchSize;
   }
 
-  @JsonProperty
+  /**
+   * Offset for this query; behaves like SQL "OFFSET". Zero means no offset. Negative values are invalid.
+   */
+  @JsonProperty("offset")
+  @JsonInclude(JsonInclude.Include.NON_DEFAULT)
+  public long getScanRowsOffset()
+  {
+    return scanRowsOffset;
+  }
+
+  /**
+   * Offset for this query; behaves like SQL "LIMIT". Will always be positive. {@link Long#MAX_VALUE} is used in

Review comment:
       Yes, you're right, fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org