[GitHub] [kafka] mumrah commented on a change in pull request #11186: KAFKA-13162: Ensure ElectLeaders is properly handled in KRaft

[GitBox <gi...@apache.org>]

mumrah commented on a change in pull request #11186:
URL: https://github.com/apache/kafka/pull/11186#discussion_r707654639



##########
File path: core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala
##########
@@ -117,6 +117,8 @@ class BrokerMetadataPublisher(conf: KafkaConfig,
                        delta: MetadataDelta,
                        newImage: MetadataImage): Unit = {
     try {
+      debug(s"Publishing delta $delta with highest offset $newHighestMetadataOffset")

Review comment:
       Are there any concerns with the MetadataDelta having a lot of records in it? I'm wondering if this could potentially dump out a lot of text into the debug log.
   
   Also, from a security perspective, is it okay to write the contents of _any_ metadata record to the debug log? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org