You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by as...@apache.org on 2021/04/15 15:04:43 UTC
[airflow] 02/02: Fix "leaking" log driver in tests
This is an automated email from the ASF dual-hosted git repository.
ash pushed a commit to branch v2-0-test
in repository https://gitbox.apache.org/repos/asf/airflow.git
commit 39593f958075471792560a1d1c04536a795c1316
Author: Ash Berlin-Taylor <as...@apache.org>
AuthorDate: Thu Apr 15 15:58:34 2021 +0100
Fix "leaking" log driver in tests
There is some problem where the stackdriver logging "leaks" out of this
test and remains configured, (where as the S3 one doesn't) but given
this test is not actually testing logs, a quick, fix is just to change
with remote logging handler we use.
---
tests/cli/commands/test_info_command.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/cli/commands/test_info_command.py b/tests/cli/commands/test_info_command.py
index 7fad6e8..e169c5c 100644
--- a/tests/cli/commands/test_info_command.py
+++ b/tests/cli/commands/test_info_command.py
@@ -119,14 +119,14 @@ class TestConfigInfoLogging(unittest.TestCase):
with conf_vars(
{
('logging', 'remote_logging'): 'True',
- ('logging', 'remote_base_log_folder'): 'stackdriver://logs-name',
+ ('logging', 'remote_base_log_folder'): 's3://logs-name',
}
):
importlib.reload(airflow_local_settings)
configure_logging()
instance = info_command.ConfigInfo(info_command.NullAnonymizer())
text = capture_show_output(instance)
- assert "stackdriver" in text
+ assert "S3TaskHandler" in text
def tearDown(self) -> None:
importlib.reload(airflow_local_settings)