You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Scott O'Bryan <da...@gmail.com> on 2007/11/21 17:47:38 UTC
JDK 1.5 Functionality
Hey Simon, update your project before generating the patches. I found a
few more stragglers. One was on a class that wasn't present when you
submitted your last patch and the other was an annotation that had to be
added to the ActionRequest wrapper. Since JSR-301 objects do no support
generics, we can't very well use them and it looks like one method
didn't have the "suppress warning" annotation.
Scott
Scott O'Bryan wrote:
> I had to re-do the patch to BrigdgeImpl because something was very
> messed up there. As a result, I actually changed this to a List
> rather then a Set. The reason is that the enumeration which fills the
> array is, by contract, unique so there is no reason to check for
> uniqueness. One thing I *DIDN'T* do is use the Collections.list which
> I forgot about, so that may even make things faster or, at the very
> least, put the ownis for performance on the JDK which I'm all about. :)
>
> Simon Lessard wrote:
>> Ok, thanks. I saw the Vector as well but didn't want to evaluate if
>> synchronization was really required or not. It seems it wasn't. I'm
>> going to check the new version to see if you included some of the
>> other possible optimizations I saw but didn't work on. The only one I
>> could not skip though was the use of an unsorted array for the
>> exclusion list. I replaced that with a TreeSet to get O(ln n) access
>> time rather than O(n).
>>
>> ~ Simon
>>
>> On Nov 20, 2007 7:22 PM, Scott O'Bryan (JIRA) <dev@myfaces.apache.org
>> <ma...@myfaces.apache.org>> wrote:
>>
>>
>> [
>>
>> https://issues.apache.org/jira/browse/PORTLETBRIDGE-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>
>>
>> <https://issues.apache.org/jira/browse/PORTLETBRIDGE-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel>
>>
>> ]
>>
>> Scott O'Bryan resolved PORTLETBRIDGE-6.
>> ---------------------------------------
>>
>> Resolution: Fixed
>>
>> Hey Simon, I fixed the few issues you had and added a couple more
>> small optimization (including replacing uses of Vector with a
>> List). That patch was very complete and very well done. Thanks...
>>
>> > JDK 1.5 Functionality
>> > ---------------------
>> >
>> > Key: PORTLETBRIDGE-6
>> > URL:
>> https://issues.apache.org/jira/browse/PORTLETBRIDGE-6
>> > Project: MyFaces Portlet Bridge
>> > Issue Type: Improvement
>> > Components: General
>> > Affects Versions: 1.0.0-SNAPSHOT
>> > Reporter: Scott O'Bryan
>> > Assignee: Simon Lessard
>> > Attachments: PORTLETBRIDGE-6.patch
>> >
>> >
>> > The bridge was originally coded to the JDK1.4 standard. Since
>> JSF1.2 requires JDK5, we should follow the JDK5 standards for
>> speed and reliability. Most notibly:
>> > * Specify generics wherever possible - especially in the
>> ExternalContext implementations which use this by default
>> > * Remove the SimpleStringBuilder class in impl and replace it's
>> usage with StringBuilder
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
>
Re: JDK 1.5 Functionality
Posted by Simon Lessard <si...@gmail.com>.
Sure, do so :)
On Nov 21, 2007 1:14 PM, Scott O'Bryan <da...@gmail.com> wrote:
> Yeah, it was one of those things. Anyway, you're a committer anyway.
> So it's not like you need to submit the patch anyway. :) I was just
> letting you know that I did some updates.
>
> Also, I'm in the process of switching over the POM Files to use the
> myFaces master v. 3. Do you have any problems with me putting you in
> the developers section of the pom file?
>
> Scott
>
> Simon Lessard wrote:
> > I updated less than 1 hour before creating the patch...
> >
> > On Nov 21, 2007 11:47 AM, Scott O'Bryan <darkarena@gmail.com
> > <ma...@gmail.com>> wrote:
> >
> > Hey Simon, update your project before generating the patches. I
> > found a
> > few more stragglers. One was on a class that wasn't present when
> you
> > submitted your last patch and the other was an annotation that had
> > to be
> > added to the ActionRequest wrapper. Since JSR-301 objects do no
> > support
> > generics, we can't very well use them and it looks like one method
> > didn't have the "suppress warning" annotation.
> >
> > Scott
> >
> > Scott O'Bryan wrote:
> > > I had to re-do the patch to BrigdgeImpl because something was very
> > > messed up there. As a result, I actually changed this to a List
> > > rather then a Set. The reason is that the enumeration which
> > fills the
> > > array is, by contract, unique so there is no reason to check for
> > > uniqueness. One thing I *DIDN'T* do is use the Collections.list
> > which
> > > I forgot about, so that may even make things faster or, at the
> very
> > > least, put the ownis for performance on the JDK which I'm all
> > about. :)
> > >
> > > Simon Lessard wrote:
> > >> Ok, thanks. I saw the Vector as well but didn't want to evaluate
> if
> > >> synchronization was really required or not. It seems it wasn't.
> > I'm
> > >> going to check the new version to see if you included some of the
> > >> other possible optimizations I saw but didn't work on. The only
> > one I
> > >> could not skip though was the use of an unsorted array for the
> > >> exclusion list. I replaced that with a TreeSet to get O(ln n)
> > access
> > >> time rather than O(n).
> > >>
> > >> ~ Simon
> > >>
> > >> On Nov 20, 2007 7:22 PM, Scott O'Bryan (JIRA) <
> > dev@myfaces.apache.org <ma...@myfaces.apache.org>
> > >> <mailto:dev@myfaces.apache.org
> > <ma...@myfaces.apache.org>>> wrote:
> > >>
> > >>
> > >> [
> > >>
> > >>
> >
> https://issues.apache.org/jira/browse/PORTLETBRIDGE-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> > <
> https://issues.apache.org/jira/browse/PORTLETBRIDGE-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> >
> > >>
> > >>
> > >>
> > <
> https://issues.apache.org/jira/browse/PORTLETBRIDGE-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> > <
> https://issues.apache.org/jira/browse/PORTLETBRIDGE-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> >>
> > >>
> > >> ]
> > >>
> > >> Scott O'Bryan resolved PORTLETBRIDGE-6.
> > >> ---------------------------------------
> > >>
> > >> Resolution: Fixed
> > >>
> > >> Hey Simon, I fixed the few issues you had and added a
> > couple more
> > >> small optimization (including replacing uses of Vector with a
> > >> List). That patch was very complete and very well done.
> > Thanks...
> > >>
> > >> > JDK 1.5 Functionality
> > >> > ---------------------
> > >> >
> > >> > Key: PORTLETBRIDGE-6
> > >> > URL:
> > >> https://issues.apache.org/jira/browse/PORTLETBRIDGE-6
> > >> > Project: MyFaces Portlet Bridge
> > >> > Issue Type: Improvement
> > >> > Components: General
> > >> > Affects Versions: 1.0.0-SNAPSHOT
> > >> > Reporter: Scott O'Bryan
> > >> > Assignee: Simon Lessard
> > >> > Attachments: PORTLETBRIDGE-6.patch
> > >> >
> > >> >
> > >> > The bridge was originally coded to the JDK1.4 standard.
> > Since
> > >> JSF1.2 requires JDK5, we should follow the JDK5 standards for
> > >> speed and reliability. Most notibly:
> > >> > * Specify generics wherever possible - especially in the
> > >> ExternalContext implementations which use this by default
> > >> > * Remove the SimpleStringBuilder class in impl and
> > replace it's
> > >> usage with StringBuilder
> > >>
> > >> --
> > >> This message is automatically generated by JIRA.
> > >> -
> > >> You can reply to this email to add a comment to the issue
> > online.
> > >>
> > >>
> > >
> > >
> >
> >
>
>
Re: JDK 1.5 Functionality
Posted by Scott O'Bryan <da...@gmail.com>.
Yeah, it was one of those things. Anyway, you're a committer anyway.
So it's not like you need to submit the patch anyway. :) I was just
letting you know that I did some updates.
Also, I'm in the process of switching over the POM Files to use the
myFaces master v. 3. Do you have any problems with me putting you in
the developers section of the pom file?
Scott
Simon Lessard wrote:
> I updated less than 1 hour before creating the patch...
>
> On Nov 21, 2007 11:47 AM, Scott O'Bryan <darkarena@gmail.com
> <ma...@gmail.com>> wrote:
>
> Hey Simon, update your project before generating the patches. I
> found a
> few more stragglers. One was on a class that wasn't present when you
> submitted your last patch and the other was an annotation that had
> to be
> added to the ActionRequest wrapper. Since JSR-301 objects do no
> support
> generics, we can't very well use them and it looks like one method
> didn't have the "suppress warning" annotation.
>
> Scott
>
> Scott O'Bryan wrote:
> > I had to re-do the patch to BrigdgeImpl because something was very
> > messed up there. As a result, I actually changed this to a List
> > rather then a Set. The reason is that the enumeration which
> fills the
> > array is, by contract, unique so there is no reason to check for
> > uniqueness. One thing I *DIDN'T* do is use the Collections.list
> which
> > I forgot about, so that may even make things faster or, at the very
> > least, put the ownis for performance on the JDK which I'm all
> about. :)
> >
> > Simon Lessard wrote:
> >> Ok, thanks. I saw the Vector as well but didn't want to evaluate if
> >> synchronization was really required or not. It seems it wasn't.
> I'm
> >> going to check the new version to see if you included some of the
> >> other possible optimizations I saw but didn't work on. The only
> one I
> >> could not skip though was the use of an unsorted array for the
> >> exclusion list. I replaced that with a TreeSet to get O(ln n)
> access
> >> time rather than O(n).
> >>
> >> ~ Simon
> >>
> >> On Nov 20, 2007 7:22 PM, Scott O'Bryan (JIRA) <
> dev@myfaces.apache.org <ma...@myfaces.apache.org>
> >> <mailto:dev@myfaces.apache.org
> <ma...@myfaces.apache.org>>> wrote:
> >>
> >>
> >> [
> >>
> >>
> https://issues.apache.org/jira/browse/PORTLETBRIDGE-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> <https://issues.apache.org/jira/browse/PORTLETBRIDGE-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel>
> >>
> >>
> >>
> <https://issues.apache.org/jira/browse/PORTLETBRIDGE-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> <https://issues.apache.org/jira/browse/PORTLETBRIDGE-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel>>
> >>
> >> ]
> >>
> >> Scott O'Bryan resolved PORTLETBRIDGE-6.
> >> ---------------------------------------
> >>
> >> Resolution: Fixed
> >>
> >> Hey Simon, I fixed the few issues you had and added a
> couple more
> >> small optimization (including replacing uses of Vector with a
> >> List). That patch was very complete and very well done.
> Thanks...
> >>
> >> > JDK 1.5 Functionality
> >> > ---------------------
> >> >
> >> > Key: PORTLETBRIDGE-6
> >> > URL:
> >> https://issues.apache.org/jira/browse/PORTLETBRIDGE-6
> >> > Project: MyFaces Portlet Bridge
> >> > Issue Type: Improvement
> >> > Components: General
> >> > Affects Versions: 1.0.0-SNAPSHOT
> >> > Reporter: Scott O'Bryan
> >> > Assignee: Simon Lessard
> >> > Attachments: PORTLETBRIDGE-6.patch
> >> >
> >> >
> >> > The bridge was originally coded to the JDK1.4 standard.
> Since
> >> JSF1.2 requires JDK5, we should follow the JDK5 standards for
> >> speed and reliability. Most notibly:
> >> > * Specify generics wherever possible - especially in the
> >> ExternalContext implementations which use this by default
> >> > * Remove the SimpleStringBuilder class in impl and
> replace it's
> >> usage with StringBuilder
> >>
> >> --
> >> This message is automatically generated by JIRA.
> >> -
> >> You can reply to this email to add a comment to the issue
> online.
> >>
> >>
> >
> >
>
>
Re: JDK 1.5 Functionality
Posted by Simon Lessard <si...@gmail.com>.
I updated less than 1 hour before creating the patch...
On Nov 21, 2007 11:47 AM, Scott O'Bryan <da...@gmail.com> wrote:
> Hey Simon, update your project before generating the patches. I found a
> few more stragglers. One was on a class that wasn't present when you
> submitted your last patch and the other was an annotation that had to be
> added to the ActionRequest wrapper. Since JSR-301 objects do no support
> generics, we can't very well use them and it looks like one method
> didn't have the "suppress warning" annotation.
>
> Scott
>
> Scott O'Bryan wrote:
> > I had to re-do the patch to BrigdgeImpl because something was very
> > messed up there. As a result, I actually changed this to a List
> > rather then a Set. The reason is that the enumeration which fills the
> > array is, by contract, unique so there is no reason to check for
> > uniqueness. One thing I *DIDN'T* do is use the Collections.list which
> > I forgot about, so that may even make things faster or, at the very
> > least, put the ownis for performance on the JDK which I'm all about. :)
> >
> > Simon Lessard wrote:
> >> Ok, thanks. I saw the Vector as well but didn't want to evaluate if
> >> synchronization was really required or not. It seems it wasn't. I'm
> >> going to check the new version to see if you included some of the
> >> other possible optimizations I saw but didn't work on. The only one I
> >> could not skip though was the use of an unsorted array for the
> >> exclusion list. I replaced that with a TreeSet to get O(ln n) access
> >> time rather than O(n).
> >>
> >> ~ Simon
> >>
> >> On Nov 20, 2007 7:22 PM, Scott O'Bryan (JIRA) <dev@myfaces.apache.org
> >> <ma...@myfaces.apache.org>> wrote:
> >>
> >>
> >> [
> >>
> >>
> https://issues.apache.org/jira/browse/PORTLETBRIDGE-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> >>
> >>
> >> <
> https://issues.apache.org/jira/browse/PORTLETBRIDGE-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> >
> >>
> >> ]
> >>
> >> Scott O'Bryan resolved PORTLETBRIDGE-6.
> >> ---------------------------------------
> >>
> >> Resolution: Fixed
> >>
> >> Hey Simon, I fixed the few issues you had and added a couple more
> >> small optimization (including replacing uses of Vector with a
> >> List). That patch was very complete and very well done. Thanks...
> >>
> >> > JDK 1.5 Functionality
> >> > ---------------------
> >> >
> >> > Key: PORTLETBRIDGE-6
> >> > URL:
> >> https://issues.apache.org/jira/browse/PORTLETBRIDGE-6
> >> > Project: MyFaces Portlet Bridge
> >> > Issue Type: Improvement
> >> > Components: General
> >> > Affects Versions: 1.0.0-SNAPSHOT
> >> > Reporter: Scott O'Bryan
> >> > Assignee: Simon Lessard
> >> > Attachments: PORTLETBRIDGE-6.patch
> >> >
> >> >
> >> > The bridge was originally coded to the JDK1.4 standard. Since
> >> JSF1.2 requires JDK5, we should follow the JDK5 standards for
> >> speed and reliability. Most notibly:
> >> > * Specify generics wherever possible - especially in the
> >> ExternalContext implementations which use this by default
> >> > * Remove the SimpleStringBuilder class in impl and replace it's
> >> usage with StringBuilder
> >>
> >> --
> >> This message is automatically generated by JIRA.
> >> -
> >> You can reply to this email to add a comment to the issue online.
> >>
> >>
> >
> >
>
>