You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2023/01/16 13:49:08 UTC

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6581: [Veeam] enable volume attach/detach in VMs with Backup Offerings

DaanHoogland commented on code in PR #6581:
URL: https://github.com/apache/cloudstack/pull/6581#discussion_r1071266959


##########
server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java:
##########
@@ -1164,6 +1166,65 @@ public void doesTargetStorageSupportDiskOfferingTestDiskOfferingTagsEqualsStorag
         Assert.assertTrue(result);
     }
 
+    @Test
+    public void validateIfVmHaveBackupsTestExceptionWhenTryToDetachVolumeFromVMWhichBackupOffering() {

Review Comment:
   ```suggestion
       public void validateIfVmHaveBackupsTestExceptionWhenTryToDetachVolumeFromVmWithBackupOffering() {
   ```
   ?
   It sounds strange as it is written now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org