You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/10 16:34:02 UTC
[GitHub] [arrow] pitrou opened a new pull request #8629: ARROW-10353: [C++] Fix handling of compression in Parquet data pages v2
pitrou opened a new pull request #8629:
URL: https://github.com/apache/arrow/pull/8629
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #8629: ARROW-10353: [C++] Fix handling of compression in Parquet data pages v2
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #8629:
URL: https://github.com/apache/arrow/pull/8629
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8629: ARROW-10353: [C++] Fix handling of compression in Parquet data pages v2
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8629:
URL: https://github.com/apache/arrow/pull/8629#issuecomment-724899187
Merging now. CI failure looks unrelated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on a change in pull request #8629: ARROW-10353: [C++] Fix handling of compression in Parquet data pages v2
Posted by GitBox <gi...@apache.org>.
emkornfield commented on a change in pull request #8629:
URL: https://github.com/apache/arrow/pull/8629#discussion_r520734627
##########
File path: cpp/src/parquet/column_reader.cc
##########
@@ -442,8 +442,10 @@ std::shared_ptr<Page> SerializedPageReader::NextPage() {
header.repetition_levels_byte_length, &levels_byte_len)) {
throw ParquetException("Levels size too large (corrupt file?)");
}
- page_buffer = DecompressIfNeeded(std::move(page_buffer), compressed_len,
- uncompressed_len, levels_byte_len);
+ if (is_compressed) {
+ page_buffer = DecompressIfNeeded(std::move(page_buffer), compressed_len,
Review comment:
could you add a comment here. The logic reads strangely to me because I would assume is_compressed is somehow accounted for in DecompressIfNeeded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8629: ARROW-10353: [C++] Fix handling of compression in Parquet data pages v2
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8629:
URL: https://github.com/apache/arrow/pull/8629#issuecomment-724819641
https://issues.apache.org/jira/browse/ARROW-10353
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org