You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by stanlyxiang <gi...@git.apache.org> on 2015/12/30 09:59:13 UTC
[GitHub] incubator-hawq pull request: HAWQ-284. Add a udf for new metadata ...
GitHub user stanlyxiang opened a pull request:
https://github.com/apache/incubator-hawq/pull/230
HAWQ-284. Add a udf for new metadata flush strategy testing.
please review, thanks.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyxiang/incubator-hawq metadata_udf
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/230.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #230
----
commit 56159c324a0549d476cd5280d4626aff18440c7e
Author: stanlyxiang <st...@gmail.com>
Date: 2015-12-30T08:58:04Z
HAWQ-284. Add a udf for new metadata flush strategy testing.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-284. Add a udf for new metadata ...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/230#discussion_r48593044
--- Diff: src/backend/cdb/cdbmetadatacache.c ---
@@ -1400,3 +1400,56 @@ extern Datum gp_metadata_cache_info(PG_FUNCTION_ARGS)
PG_RETURN_TEXT_P(cstring_to_text(message));
}
+/*
+ * Metadata Cache UDF
+ *
+ * Get entry info in the metadata cache
+ */
+extern Datum gp_metadata_cache_putentry_fortest(PG_FUNCTION_ARGS)
--- End diff --
It would be better to go with gp_metadata_cache_put_entry_for_test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-284. Add a udf for new metadata ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/230
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-284. Add a udf for new metadata ...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/230#issuecomment-167960831
The overall fix looks good. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-284. Add a udf for new metadata ...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the pull request:
https://github.com/apache/incubator-hawq/pull/230#issuecomment-167967633
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---