You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/26 14:52:11 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29550: [SPARK-32481][TESTS][FOLLOWUP] Use different directory name for MacOS

dongjoon-hyun commented on a change in pull request #29550:
URL: https://github.com/apache/spark/pull/29550#discussion_r477363350



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
##########
@@ -3116,16 +3116,17 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils {
           .getTableMetadata(TableIdentifier("tab1")).storage.locationUri.get)
 
         val fs = tablePath.getFileSystem(hadoopConf)
-        val trashRoot = fs.getTrashRoot(tablePath)
-        assert(!fs.exists(trashRoot))
+        val trashCurrent = new Path(fs.getTrashRoot(tablePath), "Current")

Review comment:
       +1 for @HyukjinKwon 's suggestion.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org