You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/06/20 19:02:25 UTC
[kudu-CR] [consensus] 'runtime' tag for consensus log FI flags
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7233
Change subject: [consensus] 'runtime' tag for consensus log FI flags
......................................................................
[consensus] 'runtime' tag for consensus log FI flags
Added the 'runtime' tag for the following consensus log fault-injection
flags:
* log_inject_latency
* log_inject_latency_ms_mean
* log_inject_latency_ms_stddev
* log_inject_thread_lifecycle_latency_ms
* fault_crash_before_append_commit
That's just to reflect their current nature "de facto".
Change-Id: I1ee1c17a75121a59b7b02bd104770d808c3536cf
---
M src/kudu/consensus/log.cc
1 file changed, 13 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/7233/1
--
To view, visit http://gerrit.cloudera.org:8080/7233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ee1c17a75121a59b7b02bd104770d808c3536cf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [consensus] 'runtime' tag for consensus log FI flags
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [consensus] 'runtime' tag for consensus log FI flags
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ee1c17a75121a59b7b02bd104770d808c3536cf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [consensus] 'runtime' tag for consensus log FI flags
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: [consensus] 'runtime' tag for consensus log FI flags
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ee1c17a75121a59b7b02bd104770d808c3536cf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [consensus] 'runtime' tag for consensus log FI flags
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [consensus] 'runtime' tag for consensus log FI flags
......................................................................
Patch Set 1:
Unrelated flake in RaftConsensusITest.TestHammerOneRow
--
To view, visit http://gerrit.cloudera.org:8080/7233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ee1c17a75121a59b7b02bd104770d808c3536cf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-HasComments: No
[kudu-CR] [consensus] 'runtime' tag for consensus log FI flags
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [consensus] 'runtime' tag for consensus log FI flags
......................................................................
[consensus] 'runtime' tag for consensus log FI flags
Added the 'runtime' tag for the following consensus log fault-injection
flags:
* log_inject_latency
* log_inject_latency_ms_mean
* log_inject_latency_ms_stddev
* log_inject_thread_lifecycle_latency_ms
* fault_crash_before_append_commit
That's just to reflect their current nature "de facto".
Change-Id: I1ee1c17a75121a59b7b02bd104770d808c3536cf
Reviewed-on: http://gerrit.cloudera.org:8080/7233
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/consensus/log.cc
1 file changed, 13 insertions(+), 4 deletions(-)
Approvals:
David Ribeiro Alves: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ee1c17a75121a59b7b02bd104770d808c3536cf
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>