[jira] Commented: (SOLR-952) TokenOrderingFilter class is defined in more than one java file

["Chris Harris (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662555#action_12662555 ] 

Chris Harris commented on SOLR-952:
-----------------------------------

I did a brief look through the svn logs:

 * The class started (I think) in org/apache/solr/util/SolrPluginUtils.java
 * In r510338 it was moved moved to org/apache/solr/util/HighlightingUtils.java.
 * In r639490 org/apache/solr/highlight/DefaultSolrHighlighter.java was created and the econd copy was added there; this revision did not, however, touch org/apache/solr/util/HighlightingUtils.java


> TokenOrderingFilter class is defined in more than one java file
> ---------------------------------------------------------------
>
>                 Key: SOLR-952
>                 URL: https://issues.apache.org/jira/browse/SOLR-952
>             Project: Solr
>          Issue Type: Bug
>          Components: highlighter
>    Affects Versions: 1.4
>            Reporter: Chris Harris
>            Priority: Minor
>
> The class TokenOrderingFilter is defined, with identical text, both in org/apache/solr/highlight/DefaultSolrHighlighter.java and org/apache/solr/util/HighlightingUtils.java. I assume this is not good, from a code maintenance perspective.
> Verified this in Solr trunk r733155.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.