You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/01/07 01:44:33 UTC

[GitHub] [iceberg] hililiwei commented on pull request #3817: Flink: FlinkInputSplit extends LocatableInputSplit instread of InputSplit

hililiwei commented on pull request #3817:
URL: https://github.com/apache/iceberg/pull/3817#issuecomment-1007072575


   > Thanks for taking this on @hililiwei!
   > 
   > I left a few nits / open questions.
   > 
   > Can we also add a test that disables locality and then performs a read to ensure that the new `FlinkInputSplit` works correctly when locality is disabled?
   
   @kbendick Thanks for your review. I'll try to add a unit test, and keep reported when get any progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org