You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org> on 2019/09/16 01:06:55 UTC
[Impala-ASF-CR] IMPALA-8228: Fix test ownership for CentOS6
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14231
Change subject: IMPALA-8228: Fix _test_ownership for CentOS6
......................................................................
IMPALA-8228: Fix _test_ownership for CentOS6
String format() with positional formatting does not work
without position argument specifiers in Python 2.6 that
ships with CentOs6.
Change-Id: I88cbfd18c963e1bd49b6af01a61c09fdf5f69157
---
M tests/authorization/test_ranger.py
1 file changed, 17 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/14231/1
--
To view, visit http://gerrit.cloudera.org:8080/14231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I88cbfd18c963e1bd49b6af01a61c09fdf5f69157
Gerrit-Change-Number: 14231
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
[Impala-ASF-CR] IMPALA-8228: Fix test ownership for CentOS6
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14231 )
Change subject: IMPALA-8228: Fix _test_ownership for CentOS6
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14231/1/tests/authorization/test_ranger.py
File tests/authorization/test_ranger.py:
http://gerrit.cloudera.org:8080/#/c/14231/1/tests/authorization/test_ranger.py@700
PS1, Line 700: )
flake8: E501 line too long (91 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/14231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88cbfd18c963e1bd49b6af01a61c09fdf5f69157
Gerrit-Change-Number: 14231
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Sep 2019 01:07:35 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8228: Fix test ownership on CentOS6
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14231 )
Change subject: IMPALA-8228: Fix _test_ownership on CentOS6
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88cbfd18c963e1bd49b6af01a61c09fdf5f69157
Gerrit-Change-Number: 14231
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Sep 2019 15:12:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8228: Fix test ownership on CentOS6
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14231 )
Change subject: IMPALA-8228: Fix _test_ownership on CentOS6
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4950/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88cbfd18c963e1bd49b6af01a61c09fdf5f69157
Gerrit-Change-Number: 14231
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Sep 2019 01:10:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8228: Fix test ownership on CentOS6
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14231 )
Change subject: IMPALA-8228: Fix _test_ownership on CentOS6
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88cbfd18c963e1bd49b6af01a61c09fdf5f69157
Gerrit-Change-Number: 14231
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Sep 2019 05:56:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8228: Fix test ownership on CentOS6
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14231 )
Change subject: IMPALA-8228: Fix _test_ownership on CentOS6
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4563/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88cbfd18c963e1bd49b6af01a61c09fdf5f69157
Gerrit-Change-Number: 14231
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Sep 2019 01:49:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8228: Fix test ownership on CentOS6
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14231
to look at the new patch set (#2).
Change subject: IMPALA-8228: Fix _test_ownership on CentOS6
......................................................................
IMPALA-8228: Fix _test_ownership on CentOS6
String format() with positional formatting does not work
without position argument specifiers in Python 2.6 that
ships with CentOs6.
Change-Id: I88cbfd18c963e1bd49b6af01a61c09fdf5f69157
---
M tests/authorization/test_ranger.py
1 file changed, 18 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/14231/2
--
To view, visit http://gerrit.cloudera.org:8080/14231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I88cbfd18c963e1bd49b6af01a61c09fdf5f69157
Gerrit-Change-Number: 14231
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8228: Fix test ownership on CentOS6
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14231 )
Change subject: IMPALA-8228: Fix _test_ownership on CentOS6
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4562/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88cbfd18c963e1bd49b6af01a61c09fdf5f69157
Gerrit-Change-Number: 14231
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Sep 2019 01:47:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8228: Fix test ownership on CentOS6
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14231 )
Change subject: IMPALA-8228: Fix _test_ownership on CentOS6
......................................................................
IMPALA-8228: Fix _test_ownership on CentOS6
String format() with positional formatting does not work
without position argument specifiers in Python 2.6 that
ships with CentOs6.
Change-Id: I88cbfd18c963e1bd49b6af01a61c09fdf5f69157
Reviewed-on: http://gerrit.cloudera.org:8080/14231
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Sahil Takiar <st...@cloudera.com>
---
M tests/authorization/test_ranger.py
1 file changed, 18 insertions(+), 18 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Sahil Takiar: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I88cbfd18c963e1bd49b6af01a61c09fdf5f69157
Gerrit-Change-Number: 14231
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>