[GitHub] [helix] kaisun2000 commented on pull request #1066: Prevent parallel controller pipelines run causing two master replicas

[GitBox <gi...@apache.org>]

kaisun2000 commented on pull request #1066:
URL: https://github.com/apache/helix/pull/1066#issuecomment-704548759


   @pkuwm, @jiajunwang,
   
   Sync-ed with @pkuwm offline. As I raise, there is another race condition in this code. This is not introduced by this pull request, it exists all the time. 
   
   Basically, it is like this:
   >Say, pause signal is added, the old lead controller see this one and the callback is in zkclient queue. the new lead controller to be also see it, but the generic controller ignored it as it is not leader yet.
   then new controller becomes leader due to old controller session expiration.
   will new controller in this case not pausing?
   
   Let us sync about shall we fix it here, or in another pull, or what should we do? I will create an issue to track it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org