You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/02/02 21:45:27 UTC

[GitHub] [arrow] lidavidm commented on a diff in pull request #34013: GH-33960: [C++] Add DeclarationToSchema and DeclarationToString helper methods.

lidavidm commented on code in PR #34013:
URL: https://github.com/apache/arrow/pull/34013#discussion_r1095114955


##########
cpp/src/arrow/compute/exec/exec_plan.cc:
##########
@@ -822,6 +868,10 @@ Result<std::unique_ptr<RecordBatchReader>> DeclarationToReader(
     }
 
     Status Close() override {
+      if (!!iterator_) {

Review Comment:
   Should this just be `!iterator_`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org