You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/01/18 16:32:35 UTC
[GitHub] [kafka] ijuma opened a new pull request #9925: MINOR: Tag `RaftEventSimulationTest` as `integration` and tweak it
ijuma opened a new pull request #9925:
URL: https://github.com/apache/kafka/pull/9925
The test takes over 1 minute to run, so it should not be considered a
unit test.
Also:
* Replace `test` prefix with `check` prefix for helper methods. A common
mistake is to forget to add the @Test annotation, so it's good to use a
different naming convention to methods that should have the annotation
versus methods that should not.
* Replace `Action` functional interface with built-in `Runnable`.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma merged pull request #9925: MINOR: Tag `RaftEventSimulationTest` as `integration` and tweak it
Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #9925:
URL: https://github.com/apache/kafka/pull/9925
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #9925: MINOR: Tag `RaftEventSimulationTest` as `integration` and tweak it
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9925:
URL: https://github.com/apache/kafka/pull/9925#issuecomment-765241792
I removed the @FunctionalInterface annotation from `Invariant`. I don't think this interfaces are used as functional interfaces and they make the system more strongly typed. `Action`, on the other hand, was playing a very similar role to `Runnable` and hence why I thought it was not worth keeping.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #9925: MINOR: Tag `RaftEventSimulationTest` as `integration` and tweak it
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9925:
URL: https://github.com/apache/kafka/pull/9925#issuecomment-766143833
@chia7712 Does this look ok to you? I am interested in making `unitTest` fast, so would like to get this merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #9925: MINOR: Tag `RaftEventSimulationTest` as `integration` and tweak it
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #9925:
URL: https://github.com/apache/kafka/pull/9925#discussion_r562445257
##########
File path: raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java
##########
@@ -59,6 +60,7 @@
import static org.junit.jupiter.api.Assertions.fail;
import static org.junit.jupiter.api.Assumptions.assumeTrue;
Review comment:
Is ```assumeTrue``` used in this test? I test ```RaftEventSimulationTest`` but there is no ignored test cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9925: MINOR: Tag `RaftEventSimulationTest` as `integration` and tweak it
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9925:
URL: https://github.com/apache/kafka/pull/9925#issuecomment-765241389
> What are you suggesting instead of Validation and Invariant? Runnable?
Runnable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #9925: MINOR: Tag `RaftEventSimulationTest` as `integration` and tweak it
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9925:
URL: https://github.com/apache/kafka/pull/9925#issuecomment-765239810
@chia7712 What are you suggesting instead of `Validation` and `Invariant`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma edited a comment on pull request #9925: MINOR: Tag `RaftEventSimulationTest` as `integration` and tweak it
Posted by GitBox <gi...@apache.org>.
ijuma edited a comment on pull request #9925:
URL: https://github.com/apache/kafka/pull/9925#issuecomment-765239810
@chia7712 What are you suggesting instead of `Validation` and `Invariant`? `Runnable`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #9925: MINOR: Tag `RaftEventSimulationTest` as `integration` and tweak it
Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #9925:
URL: https://github.com/apache/kafka/pull/9925#discussion_r562472766
##########
File path: raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java
##########
@@ -59,6 +60,7 @@
import static org.junit.jupiter.api.Assertions.fail;
import static org.junit.jupiter.api.Assumptions.assumeTrue;
Review comment:
Good catch, removed since it's not currently needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org