You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/09/01 20:51:09 UTC

[kudu-CR] gradle: also inject mkdir when modifying gradlew 

Hello Dan Burkert, Grant Henke,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/7939

to review the following change.

Change subject: gradle: also inject mkdir when modifying gradlew
......................................................................

gradle: also inject mkdir when modifying gradlew

Now that there are no committed files in the gradle/wrapper subdirectory,
it isn't guaranteed to exist, and if it doesn't, curl fails.

Change-Id: Id577d4f74c408723ac18cbfbdaca12f9affca483
---
M java/gradle/wrapper.gradle
M java/gradlew
2 files changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/7939/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7939
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id577d4f74c408723ac18cbfbdaca12f9affca483
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>

[kudu-CR] gradle: also inject mkdir when modifying gradlew

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change.

Change subject: gradle: also inject mkdir when modifying gradlew
......................................................................


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7939
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id577d4f74c408723ac18cbfbdaca12f9affca483
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] gradle: also inject mkdir when modifying gradlew

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: gradle: also inject mkdir when modifying gradlew
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7939
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id577d4f74c408723ac18cbfbdaca12f9affca483
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] gradle: also inject mkdir when modifying gradlew

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.

Change subject: gradle: also inject mkdir when modifying gradlew
......................................................................


gradle: also inject mkdir when modifying gradlew

Now that there are no committed files in the gradle/wrapper subdirectory,
it isn't guaranteed to exist, and if it doesn't, curl fails.

Change-Id: Id577d4f74c408723ac18cbfbdaca12f9affca483
Reviewed-on: http://gerrit.cloudera.org:8080/7939
Reviewed-by: Grant Henke <gr...@gmail.com>
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
---
M java/gradle/wrapper.gradle
M java/gradlew
2 files changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Grant Henke: Looks good to me, but someone else must approve
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7939
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id577d4f74c408723ac18cbfbdaca12f9affca483
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins