You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/02/02 06:45:33 UTC
[GitHub] [echarts-doc] susiwen8 opened a new pull request #160: chore: update code style
susiwen8 opened a new pull request #160:
URL: https://github.com/apache/echarts-doc/pull/160
Remove some limitation in `Compatibility`.
Also I was wondering should we add `space-in-parens`, cause there are many inconsistence in code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] plainheart commented on a change in pull request #160: chore: update code style
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #160:
URL: https://github.com/apache/echarts-doc/pull/160#discussion_r568464060
##########
File path: zh/coding-standard.md
##########
@@ -563,18 +559,18 @@ String.prototype.trim = function () {
### 变量
-**[强制]** 变量必须用 `var` 声明，且一个 `var` 不能同时声明多个变量。
+**[强制]** 优先使用`const`声明变量 且一行不能同时声明多个变量。
Review comment:
Should add one `，`. The others look good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] susiwen8 commented on a change in pull request #160: chore: update code style
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on a change in pull request #160:
URL: https://github.com/apache/echarts-doc/pull/160#discussion_r568474917
##########
File path: zh/coding-standard.md
##########
@@ -563,18 +559,18 @@ String.prototype.trim = function () {
### 变量
-**[强制]** 变量必须用 `var` 声明，且一个 `var` 不能同时声明多个变量。
+**[强制]** 优先使用`const`声明变量 且一行不能同时声明多个变量。
Review comment:
@plainheart Thanks, comma has added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] pissang merged pull request #160: chore: update code style
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #160:
URL: https://github.com/apache/echarts-doc/pull/160
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] susiwen8 commented on a change in pull request #160: chore: update code style
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on a change in pull request #160:
URL: https://github.com/apache/echarts-doc/pull/160#discussion_r568474917
##########
File path: zh/coding-standard.md
##########
@@ -563,18 +559,18 @@ String.prototype.trim = function () {
### 变量
-**[强制]** 变量必须用 `var` 声明，且一个 `var` 不能同时声明多个变量。
+**[强制]** 优先使用`const`声明变量 且一行不能同时声明多个变量。
Review comment:
@plainheart Thanks, comma has added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] plainheart commented on a change in pull request #160: chore: update code style
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #160:
URL: https://github.com/apache/echarts-doc/pull/160#discussion_r568464060
##########
File path: zh/coding-standard.md
##########
@@ -563,18 +559,18 @@ String.prototype.trim = function () {
### 变量
-**[强制]** 变量必须用 `var` 声明，且一个 `var` 不能同时声明多个变量。
+**[强制]** 优先使用`const`声明变量 且一行不能同时声明多个变量。
Review comment:
Should add one `，`. The others look good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org