You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "uschindler (via GitHub)" <gi...@apache.org> on 2023/05/25 09:14:37 UTC
[GitHub] [lucene] uschindler opened a new pull request, #12329: Remove jdk.internal classes from superclass or interfaces during extraction
uschindler opened a new pull request, #12329:
URL: https://github.com/apache/lucene/pull/12329
This fixes problem on branch_9x backport (#12327) where the private superclasses are not available in Java 11.
On Java 17 it just worked so we didn't figure. :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] ChrisHegarty commented on pull request #12329: Remove jdk.internal classes from superclass or interfaces during extraction
Posted by "ChrisHegarty (via GitHub)" <gi...@apache.org>.
ChrisHegarty commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1562595492
I'm clearly doing something wrong, but I cherrypicked this into the 9x_panama_vector branch locally, and it still fails. I dunno why, it should work. Checking that my env is correct and that I've not missed something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12329: Remove jdk.internal classes from superclass or interfaces during extraction
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1562628098
The problem is the signature, I verified it. Let me think how to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12329: Remove jdk.internal classes from superclass or interfaces during extraction
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1562592848
Looks like this:
```
> Task :lucene:core:generateJdkApiJar19
Transforming 31 class files in [/modules/java.base]...
Writing 26 visible classes for [/modules/java.base]...
Writing stub for class: java/lang/foreign/AbstractLayout
Writing stub for class: java/lang/foreign/Addressable
Writing stub for class: java/lang/foreign/FunctionDescriptor
Writing stub for class: java/lang/foreign/GroupLayout
Writing stub for class: java/lang/foreign/Linker
Writing stub for class: java/lang/foreign/MemoryAddress
Writing stub for class: java/lang/foreign/MemoryLayout
Writing stub for class: java/lang/foreign/MemoryLayout$PathElement
Writing stub for class: java/lang/foreign/MemorySegment
Writing stub for class: java/lang/foreign/MemorySession
Writing stub for class: java/lang/foreign/SegmentAllocator
Writing stub for class: java/lang/foreign/SequenceLayout
Writing stub for class: java/lang/foreign/SymbolLookup
Writing stub for class: java/lang/foreign/VaList
Writing stub for class: java/lang/foreign/VaList$Builder
Writing stub for class: java/lang/foreign/ValueLayout
Writing stub for class: java/lang/foreign/ValueLayout$OfAddress
Writing stub for class: java/lang/foreign/ValueLayout$OfBoolean
Writing stub for class: java/lang/foreign/ValueLayout$OfByte
Writing stub for class: java/lang/foreign/ValueLayout$OfChar
Writing stub for class: java/lang/foreign/ValueLayout$OfDouble
Writing stub for class: java/lang/foreign/ValueLayout$OfFloat
Writing stub for class: java/lang/foreign/ValueLayout$OfInt
Writing stub for class: java/lang/foreign/ValueLayout$OfLong
Writing stub for class: java/lang/foreign/ValueLayout$OfShort
Writing stub for class: java/nio/channels/FileChannel
Referenced classes not included: [java/nio/channels/ScatteringByteChannel, java/nio/channels/GatheringByteChannel, java/nio/channels/SeekableByteChannel, java/nio/channels/spi/AbstractInterruptibleChannel, java/lang/AutoCloseable, java/lang/Object]
> Task :lucene:core:generateJdkApiJar20
Transforming 30 class files in [/modules/java.base]...
Writing 29 visible classes for [/modules/java.base]...
Writing stub for class: java/lang/foreign/Arena
Writing stub for class: java/lang/foreign/FunctionDescriptor
Writing stub for class: java/lang/foreign/GroupLayout
Writing stub for class: java/lang/foreign/Linker
Writing stub for class: java/lang/foreign/Linker$Option
Writing stub for class: java/lang/foreign/Linker$Option$CaptureCallState
Writing stub for class: java/lang/foreign/MemoryLayout
Writing stub for class: java/lang/foreign/MemoryLayout$PathElement
Writing stub for class: java/lang/foreign/MemorySegment
Writing stub for class: java/lang/foreign/PaddingLayout
Writing stub for class: java/lang/foreign/SegmentAllocator
Writing stub for class: java/lang/foreign/SegmentScope
Writing stub for class: java/lang/foreign/SequenceLayout
Writing stub for class: java/lang/foreign/StructLayout
Writing stub for class: java/lang/foreign/SymbolLookup
Writing stub for class: java/lang/foreign/UnionLayout
Writing stub for class: java/lang/foreign/VaList
Writing stub for class: java/lang/foreign/VaList$Builder
Writing stub for class: java/lang/foreign/ValueLayout
Writing stub for class: java/lang/foreign/ValueLayout$OfAddress
Writing stub for class: java/lang/foreign/ValueLayout$OfBoolean
Writing stub for class: java/lang/foreign/ValueLayout$OfByte
Writing stub for class: java/lang/foreign/ValueLayout$OfChar
Writing stub for class: java/lang/foreign/ValueLayout$OfDouble
Writing stub for class: java/lang/foreign/ValueLayout$OfFloat
Writing stub for class: java/lang/foreign/ValueLayout$OfInt
Writing stub for class: java/lang/foreign/ValueLayout$OfLong
Writing stub for class: java/lang/foreign/ValueLayout$OfShort
Writing stub for class: java/nio/channels/FileChannel
Referenced classes not included: [java/nio/channels/ScatteringByteChannel, java/nio/channels/GatheringByteChannel, java/nio/channels/SeekableByteChannel, java/nio/channels/spi/AbstractInterruptibleChannel, java/lang/AutoCloseable, java/lang/Object]
Transforming 189 class files in [/modules/jdk.incubator.vector]...
Writing 21 visible classes for [/modules/jdk.incubator.vector]...
Writing stub for class: jdk/incubator/vector/AbstractVector
Writing stub for class: jdk/incubator/vector/ByteVector
Writing stub for class: jdk/incubator/vector/DoubleVector
Writing stub for class: jdk/incubator/vector/FloatVector
Writing stub for class: jdk/incubator/vector/IntVector
Writing stub for class: jdk/incubator/vector/LongVector
Writing stub for class: jdk/incubator/vector/ShortVector
Writing stub for class: jdk/incubator/vector/Vector
Writing stub for class: jdk/incubator/vector/VectorMask
Writing stub for class: jdk/incubator/vector/VectorOperators
Writing stub for class: jdk/incubator/vector/VectorOperators$Associative
Writing stub for class: jdk/incubator/vector/VectorOperators$Binary
Writing stub for class: jdk/incubator/vector/VectorOperators$Comparison
Writing stub for class: jdk/incubator/vector/VectorOperators$Conversion
Writing stub for class: jdk/incubator/vector/VectorOperators$Operator
Writing stub for class: jdk/incubator/vector/VectorOperators$Ternary
Writing stub for class: jdk/incubator/vector/VectorOperators$Test
Writing stub for class: jdk/incubator/vector/VectorOperators$Unary
Writing stub for class: jdk/incubator/vector/VectorShape
Writing stub for class: jdk/incubator/vector/VectorShuffle
Writing stub for class: jdk/incubator/vector/VectorSpecies
Referenced classes not included: [java/lang/Enum, java/lang/Object]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12329: Handle jdk.internal classes mentioned in vector superclass or interfaces during extraction
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1563162753
> Here is this mess with the `@hidden` Javadoc tag explained: https://bugs.openjdk.org/browse/JDK-8277074
>
> As you see we are in the areas of heavy hacks with visibility. So we can't solve this in a general way. I tend to hardcode the exact classes needed into the extractor as patterns.
>
> I will also change the patterns a bit by having a list of filename patterns without module per Java version.
By the way in Java 19 you see the `@hidden` Javadoc classes also in the public Javadocs. So it is still a mess (now behind the scenes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12329: Remove jdk.internal classes from superclass or interfaces during extraction
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1562669185
This can't be repaired, as the generic signature refers to the other class which has generics, too. By replacing it with `java.lang.Object` it breaks horribly (as `Object` has no type parameters).
If I just null out the generic signature, javac reports:
```
bad class file: C:\Users\Uwe Schindler\Projects\lucene\lucene\lucene\core\src\generated\jdk\jdk20.apijar(/jdk/incubator/vector/Vector.class)
undeclared type variable: E
```
So the only route here is my original idea to include the internal classes intothe JAR -- unfortunately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12329: Handle jdk.internal classes mentioned in vector superclass or interfaces during extraction
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1563109161
The Java 21 branch was also updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12329: Remove jdk.internal classes from superclass or interfaces during extraction
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1562608390
Here you see it, must be the signature as it shows generics:
```
>javap Vector.class | grep internal
public abstract class jdk.incubator.vector.Vector<E> extends jdk.internal.vm.vector.VectorSupport$Vector<E> {
```
Uwe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12329: Handle jdk.internal classes mentioned in vector superclass or interfaces during extraction
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1562869045
I have seen this, too, but does this break in the Java 11 compiler?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12329: Remove jdk.internal classes from superclass or interfaces during extraction
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1562591375
Thanks for review, i added a logging statement to show all classes which were not referenced but not included. This would solve problems like this in future.
Will merge when CI is happy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12329: Handle jdk.internal classes mentioned in vector superclass or interfaces during extraction
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1563108274
I would merge this to the 9x_panama_branch. I don't want the huge binary file go into the main repo's Git state (I am afraid of Dawid and Robert about binaries in checkouts).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12329: Handle jdk.internal classes mentioned in vector superclass or interfaces during extraction
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1563072964
@ChrisHegarty: do you want to crosscheck the 9.x branch? (don't forget to re-add the java/lang/Objects class pattern).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12329: Remove jdk.internal classes from superclass or interfaces during extraction
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1562682086
I think I can fix it, we need a SignatureVisitor to remove the superclass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] ChrisHegarty commented on pull request #12329: Handle jdk.internal classes mentioned in vector superclass or interfaces during extraction
Posted by "ChrisHegarty (via GitHub)" <gi...@apache.org>.
ChrisHegarty commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1562881287
yeah, it breaks - in the same way - "class file for jdk.internal.vm.vector.VectorSupport not found"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12329: Handle jdk.internal classes mentioned in vector superclass or interfaces during extraction
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1562916004
I have no idea way they had did this crazy class layout. There's also the special javadoc tag "@hidden" which looks like a crazy workaround.
It looks like we have to include also the superclasss. There are also interfaces which on the other hand are not referenced downstream, so the current code to hide them is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12329: Remove jdk.internal classes from superclass or interfaces during extraction
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1562601434
Ahhhhh, the signature because it is generic....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] ChrisHegarty commented on pull request #12329: Remove jdk.internal classes from superclass or interfaces during extraction
Posted by "ChrisHegarty (via GitHub)" <gi...@apache.org>.
ChrisHegarty commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1562716975
For now, I just updated the glob in the 9x Panama vector branch to include VectorSupport, see https://github.com/apache/lucene/pull/12327/commits/7c353f045cfbc42de33818add402c9de564e3ee6
```diff
--- a/gradle/generation/extract-jdk-apis/ExtractJdkApis.java
+++ b/gradle/generation/extract-jdk-apis/ExtractJdkApis.java
@@ -50,7 +50,7 @@ public final class ExtractJdkApis {
private static final FileTime FIXED_FILEDATE = FileTime.from(Instant.parse("2022-01-01T00:00:00Z"));
static final Map<String,String> CLASSFILE_MATCHERS = Map.of(
- "java.base", "glob:java/{lang/foreign/*,nio/channels/FileChannel,util/Objects}.class",
+ "java.base", "glob:{java/lang/foreign/*,java/nio/channels/FileChannel,java/util/Objects,jdk/internal/vm/vector/VectorSupport*}.class",
"jdk.incubator.vector", "glob:jdk/incubator/vector/*.class"
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] ChrisHegarty commented on pull request #12329: Remove jdk.internal classes from superclass or interfaces during extraction
Posted by "ChrisHegarty (via GitHub)" <gi...@apache.org>.
ChrisHegarty commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1562567181
I think that your proposed change is fine. Alternatively we could determine accessibility / visibility of the super class / interface by reading it from the jrt. But this is probably overkill for this one particular case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12329: Remove jdk.internal classes from superclass or interfaces during extraction
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1562670506
Keep the backport open, I will try to fix it later this afternoon, I first have to do something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] ChrisHegarty commented on pull request #12329: Handle jdk.internal classes mentioned in vector superclass or interfaces during extraction
Posted by "ChrisHegarty (via GitHub)" <gi...@apache.org>.
ChrisHegarty commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1562968126
> So we can't solve this in a general way. I tend to hardcode the exact classes needed into the extractor as patterns.
++ while not perfect, it is understandable and maintainable. The extra logging is also very welcome, which will help future potential changes in this area.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12329: Handle jdk.internal classes mentioned in vector superclass or interfaces during extraction
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1563096626
Thanks, as always a fun to work together!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] ChrisHegarty commented on pull request #12329: Remove jdk.internal classes from superclass or interfaces during extraction
Posted by "ChrisHegarty (via GitHub)" <gi...@apache.org>.
ChrisHegarty commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1562612645
Here's what I'm doing:
```
$ ./gradlew :lucene:core:regenerate
```
Debugging the extractor Cleaner, I can see that _superName_ is replaced with _java/lang/Object_. But for some reason the apijar is not updated! ?
```
$ cat T.java
import jdk.incubator.vector.*;
public class T {
static final FloatVector acc1 = FloatVector.zero(FloatVector.SPECIES_PREFERRED);
}
$
$ /Users/chegar/binaries/jdk-11.0.12.jdk/Contents/Home/bin/javac --patch-module java.base=lucene/core/src/generated/jdk/jdk20.apijar --add-exports=java.base/jdk.incubator.vector=ALL-UNNAMED T.java
T.java:4: error: cannot access VectorSupport
static final FloatVector acc1 = FloatVector.zero(FloatVector.SPECIES_PREFERRED);
^
class file for jdk.internal.vm.vector.VectorSupport not found
```
```
cd lucene/core/src/generated/jdk
$ unzip jdk20.apijar
...
javap -v -p jdk/incubator/vector/Vector.class | more
Classfile /Users/chegar/git/lucene/lucene/core/src/generated/jdk/jdk/incubator/vector/Vector.class
Last modified 1 Jan 2022; size 10382 bytes
MD5 checksum 9d8f0c7cc22956e602994bfc4f1507b4
public abstract class jdk.incubator.vector.Vector<E extends java.lang.Object> extends jdk.internal.vm.vector.VectorSupport$Vector<E>
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12329: Remove jdk.internal classes from superclass or interfaces during extraction
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1562600855
Did you generate everything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12329: Handle jdk.internal classes mentioned in vector superclass or interfaces during extraction
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1563064848
OK, I committed my final fix. Rewrote the modules / java version static settings at top of file:
- For each Java version it has a list of glob patterns
- To simplify the common patterns are strings
- The patterns are combined and the filesystem is walked only one time
The internal classes are explicitely specifid until no more were left over in the warning at end (including the superclass).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] ChrisHegarty commented on pull request #12329: Handle jdk.internal classes mentioned in vector superclass or interfaces during extraction
Posted by "ChrisHegarty (via GitHub)" <gi...@apache.org>.
ChrisHegarty commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1563101798
> Thanks, as always a fun to work together!
Absolutely. And thanks for fixing this so quickly. So how to proceed? I can merge in this PR commit (to he 9x_panama_branch), or we can coordinate and you can backport very quickly afterwards?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12329: Handle jdk.internal classes mentioned in vector superclass or interfaces during extraction
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1562916849
Have a look at the whole class: https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/jdk/internal/vm/vector/VectorSupport.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12329: Handle jdk.internal classes mentioned in vector superclass or interfaces during extraction
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1562951652
Here is this mess with the `@hidden` Javadoc tag explained: https://bugs.openjdk.org/browse/JDK-8277074
As you see we are in the areas of heavy hacks with visibility. So we can't solve this in a general way. I tend to hardcode the exact classes needed into the extractor as patterns.
I will also change the patterns a bit by having a list of filename patterns without module per Java version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] ChrisHegarty commented on pull request #12329: Handle jdk.internal classes mentioned in vector superclass or interfaces during extraction
Posted by "ChrisHegarty (via GitHub)" <gi...@apache.org>.
ChrisHegarty commented on PR #12329:
URL: https://github.com/apache/lucene/pull/12329#issuecomment-1562851681
Argh! inner classes!!! We still need the enclosing class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler merged pull request #12329: Handle jdk.internal classes mentioned in vector superclass or interfaces during extraction
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler merged PR #12329:
URL: https://github.com/apache/lucene/pull/12329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org