You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2021/06/24 03:15:57 UTC

[Impala-ASF-CR] IMPALA-10765: Allow firing insert events with empty files

Hello Vihang Karajgaonkar, Zoltan Borok-Nagy, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17629

to look at the new patch set (#2).

Change subject: IMPALA-10765: Allow firing insert events with empty files
......................................................................

IMPALA-10765: Allow firing insert events with empty files

When INSERT or the INSERT part of a CTAS statement produces empty
results, catalogd will hit a Precondition check in createInsertEvents()
if the statement is not specified with OVERWRITE. This patch removes the
checks to relax the restriction. This is consistent with Hive since Hive
also fires insert events on empty insert results.

Tests
 - Add e2e test

Change-Id: Id708f38302b37d7e09435e7b8b0c9fc071659606
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M tests/custom_cluster/test_event_processing.py
2 files changed, 35 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/17629/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id708f38302b37d7e09435e7b8b0c9fc071659606
Gerrit-Change-Number: 17629
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>