You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/06/30 19:51:07 UTC
[GitHub] [trafficserver] bneradt opened a new pull request, #8935: Make clang-format not modify files on initial invocation
bneradt opened a new pull request, #8935:
URL: https://github.com/apache/trafficserver/pull/8935
ink_autoconf.h.in and ink_autoconf.h are generated files created with
autoconf. After they are made, if the user builds with them and then
calls the clang-format target, clang-format will dutifully format these
files according to our .clang-format specification. This then results in
a future invocation of make rebuilding most of the files in the
repository because those file are fundamental dependencies in our
repository.
This patch addresses the issue by simply not calling clang-format on
these generated, not checked in, files.
This fixes #8934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8935: Make clang-format not modify ink_autoconf.h.in and ink_autoconf.h
Posted by GitBox <gi...@apache.org>.
zwoop commented on PR #8935:
URL: https://github.com/apache/trafficserver/pull/8935#issuecomment-1176458049
Cherry-picked to v9.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt merged pull request #8935: Make clang-format not modify ink_autoconf.h.in and ink_autoconf.h
Posted by GitBox <gi...@apache.org>.
bneradt merged PR #8935:
URL: https://github.com/apache/trafficserver/pull/8935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org