You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Mark Miller (JIRA)" <ji...@apache.org> on 2010/03/08 16:42:27 UTC
[jira] Created: (SOLR-1812) StreamingUpdateSolrServer creates an
OutputStreamWriter that it never closes
StreamingUpdateSolrServer creates an OutputStreamWriter that it never closes
----------------------------------------------------------------------------
Key: SOLR-1812
URL: https://issues.apache.org/jira/browse/SOLR-1812
Project: Solr
Issue Type: Bug
Components: clients - java
Affects Versions: 1.4
Reporter: Mark Miller
Priority: Minor
Fix For: 1.5
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1812) StreamingUpdateSolrServer creates an
OutputStreamWriter that it never closes
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842728#action_12842728 ]
Mark Miller commented on SOLR-1812:
-----------------------------------
I do not agree that this is a correct use of the API.
OutputStreamWriter.close does not simply close the outputstream, nor does it simply flush and then close the outputstream. What it does it actually impl dependent, but its more than that in either case. This API misuse is just asking for trouble.
> StreamingUpdateSolrServer creates an OutputStreamWriter that it never closes
> ----------------------------------------------------------------------------
>
> Key: SOLR-1812
> URL: https://issues.apache.org/jira/browse/SOLR-1812
> Project: Solr
> Issue Type: Bug
> Components: clients - java
> Affects Versions: 1.4
> Reporter: Mark Miller
> Priority: Minor
> Fix For: 1.5
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1812) StreamingUpdateSolrServer creates an
OutputStreamWriter that it never closes
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842717#action_12842717 ]
Shalin Shekhar Mangar commented on SOLR-1812:
---------------------------------------------
Closing the OutputStreamWriter will close the underlying OutputStream. The HttpClient will automatically do that once the request has been sent so there is no leak here.
> StreamingUpdateSolrServer creates an OutputStreamWriter that it never closes
> ----------------------------------------------------------------------------
>
> Key: SOLR-1812
> URL: https://issues.apache.org/jira/browse/SOLR-1812
> Project: Solr
> Issue Type: Bug
> Components: clients - java
> Affects Versions: 1.4
> Reporter: Mark Miller
> Priority: Minor
> Fix For: 1.5
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.