You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aurora.apache.org by Zameer Manji <zm...@gmail.com> on 2013/12/11 01:38:45 UTC
Review Request 16168: Fix noSlotsFound stat in Preemptor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16168/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
Repository: aurora
Description
-------
This changes the noSlotsFound stat in the Preemptor to be incremented after all the slaves have been searched not after each one.
Diffs
-----
src/main/java/com/twitter/aurora/scheduler/async/Preemptor.java 6ad5f08ef27ee03cb6a78a58e9579eca1aadda24
Diff: https://reviews.apache.org/r/16168/diff/
Testing
-------
./gradlew clean build
Thanks,
Zameer Manji
Re: Review Request 16168: Fix noSlotsFound stat in Preemptor
Posted by Bill Farner <te...@gmail.com>.
Didn't forget, just didn't have a chance.
On Dec 10, 2013 5:00 PM, "Zameer Manji" <zm...@gmail.com> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16168/
>
> On December 10th, 2013, 4:39 p.m. PST, *Bill Farner* wrote:
>
> Ship It!
>
> You forgot to commit it as well.
>
>
> - Zameer
>
> On December 10th, 2013, 4:38 p.m. PST, Zameer Manji wrote:
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill
> Farner.
> By Zameer Manji.
>
> *Updated Dec. 10, 2013, 4:38 p.m.*
> *Repository: * aurora
> Description
>
> This changes the noSlotsFound stat in the Preemptor to be incremented after all the slaves have been searched not after each one.
>
> Testing
>
> ./gradlew clean build
>
> Diffs
>
> - src/main/java/com/twitter/aurora/scheduler/async/Preemptor.java
> (6ad5f08ef27ee03cb6a78a58e9579eca1aadda24)
>
> View Diff <https://reviews.apache.org/r/16168/diff/>
>
Re: Review Request 16168: Fix noSlotsFound stat in Preemptor
Posted by Zameer Manji <zm...@gmail.com>.
> On Dec. 10, 2013, 4:39 p.m., Bill Farner wrote:
> > Ship It!
You forgot to commit it as well.
- Zameer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16168/#review30154
-----------------------------------------------------------
On Dec. 10, 2013, 4:38 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16168/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2013, 4:38 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This changes the noSlotsFound stat in the Preemptor to be incremented after all the slaves have been searched not after each one.
>
>
> Diffs
> -----
>
> src/main/java/com/twitter/aurora/scheduler/async/Preemptor.java 6ad5f08ef27ee03cb6a78a58e9579eca1aadda24
>
> Diff: https://reviews.apache.org/r/16168/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 16168: Fix noSlotsFound stat in Preemptor
Posted by Bill Farner <wf...@apache.org>.
> On Dec. 11, 2013, 12:39 a.m., Bill Farner wrote:
> > Ship It!
>
> Zameer Manji wrote:
> You forgot to commit it as well.
You were too fast for me, wasn't in a spot to push. This is now on master.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16168/#review30154
-----------------------------------------------------------
On Dec. 11, 2013, 12:38 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16168/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2013, 12:38 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This changes the noSlotsFound stat in the Preemptor to be incremented after all the slaves have been searched not after each one.
>
>
> Diffs
> -----
>
> src/main/java/com/twitter/aurora/scheduler/async/Preemptor.java 6ad5f08ef27ee03cb6a78a58e9579eca1aadda24
>
> Diff: https://reviews.apache.org/r/16168/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 16168: Fix noSlotsFound stat in Preemptor
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16168/#review30154
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Dec. 11, 2013, 12:38 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16168/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2013, 12:38 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This changes the noSlotsFound stat in the Preemptor to be incremented after all the slaves have been searched not after each one.
>
>
> Diffs
> -----
>
> src/main/java/com/twitter/aurora/scheduler/async/Preemptor.java 6ad5f08ef27ee03cb6a78a58e9579eca1aadda24
>
> Diff: https://reviews.apache.org/r/16168/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 16168: Fix noSlotsFound stat in Preemptor
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16168/#review30156
-----------------------------------------------------------
Ship it!
Love diffs like this one!
- Maxim Khutornenko
On Dec. 11, 2013, 12:38 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16168/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2013, 12:38 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This changes the noSlotsFound stat in the Preemptor to be incremented after all the slaves have been searched not after each one.
>
>
> Diffs
> -----
>
> src/main/java/com/twitter/aurora/scheduler/async/Preemptor.java 6ad5f08ef27ee03cb6a78a58e9579eca1aadda24
>
> Diff: https://reviews.apache.org/r/16168/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 16168: Fix noSlotsFound stat in Preemptor
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16168/#review30159
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Dec. 10, 2013, 4:38 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16168/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2013, 4:38 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This changes the noSlotsFound stat in the Preemptor to be incremented after all the slaves have been searched not after each one.
>
>
> Diffs
> -----
>
> src/main/java/com/twitter/aurora/scheduler/async/Preemptor.java 6ad5f08ef27ee03cb6a78a58e9579eca1aadda24
>
> Diff: https://reviews.apache.org/r/16168/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build
>
>
> Thanks,
>
> Zameer Manji
>
>