You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/01/07 09:27:03 UTC
[GitHub] [kylin] codecov-io commented on pull request #1539: [KYLIN-4826] JobRunner should not do onExecuteError or onExecuteFinishe…
codecov-io commented on pull request #1539:
URL: https://github.com/apache/kylin/pull/1539#issuecomment-755995680
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1539?src=pr&el=h1) Report
> Merging [#1539](https://codecov.io/gh/apache/kylin/pull/1539?src=pr&el=desc) (2833b78) into [master](https://codecov.io/gh/apache/kylin/commit/5c12d08be9713266ae060796f6e85726cedd6256?el=desc) (5c12d08) will **decrease** coverage by `0.01%`.
> The diff coverage is `30.76%`.
[](https://codecov.io/gh/apache/kylin/pull/1539?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1539 +/- ##
============================================
- Coverage 25.42% 25.41% -0.02%
+ Complexity 6764 6762 -2
============================================
Files 1508 1509 +1
Lines 93918 93926 +8
Branches 13158 13159 +1
============================================
- Hits 23879 23871 -8
- Misses 67660 67671 +11
- Partials 2379 2384 +5
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1539?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/kylin/job/common/ShellExecutable.java](https://codecov.io/gh/apache/kylin/pull/1539/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9jb21tb24vU2hlbGxFeGVjdXRhYmxlLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/kylin/job/execution/BrokenExecutable.java](https://codecov.io/gh/apache/kylin/pull/1539/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vQnJva2VuRXhlY3V0YWJsZS5qYXZh) | `60.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...ylin/job/impl/threadpool/DistributedScheduler.java](https://codecov.io/gh/apache/kylin/pull/1539/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGlzdHJpYnV0ZWRTY2hlZHVsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/kylin/job/impl/threadpool/IJobRunner.java](https://codecov.io/gh/apache/kylin/pull/1539/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvSUpvYlJ1bm5lci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...org/apache/kylin/engine/flink/FlinkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1539/diff?src=pr&el=tree#diff-ZW5naW5lLWZsaW5rL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvZmxpbmsvRmxpbmtFeGVjdXRhYmxlLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../kylin/engine/mr/common/HadoopShellExecutable.java](https://codecov.io/gh/apache/kylin/pull/1539/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0hhZG9vcFNoZWxsRXhlY3V0YWJsZS5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...he/kylin/engine/mr/common/MapReduceExecutable.java](https://codecov.io/gh/apache/kylin/pull/1539/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL01hcFJlZHVjZUV4ZWN1dGFibGUuamF2YQ==) | `12.58% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...ache/kylin/engine/mr/steps/CopyDictionaryStep.java](https://codecov.io/gh/apache/kylin/pull/1539/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvQ29weURpY3Rpb25hcnlTdGVwLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...che/kylin/engine/mr/steps/MergeDictionaryStep.java](https://codecov.io/gh/apache/kylin/pull/1539/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvTWVyZ2VEaWN0aW9uYXJ5U3RlcC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...che/kylin/engine/mr/steps/MergeStatisticsStep.java](https://codecov.io/gh/apache/kylin/pull/1539/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvTWVyZ2VTdGF0aXN0aWNzU3RlcC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [33 more](https://codecov.io/gh/apache/kylin/pull/1539/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1539?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1539?src=pr&el=footer). Last update [5c12d08...2833b78](https://codecov.io/gh/apache/kylin/pull/1539?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org