You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@twopensource.com> on 2014/09/09 23:05:03 UTC
Review Request 25483: Transaction all SQL under MemStorage
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25483/
-----------------------------------------------------------
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Summary (updated)
-----------------
Transaction all SQL under MemStorage
Bugs: AURORA-694
https://issues.apache.org/jira/browse/AURORA-694
Repository: aurora
Description (updated)
-------
This commit ensures all delegated tables are accessed via a transaction via MemStorage.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java d7d350ee85510e75804322ebf6a877e35bf8d0d3
src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java a042fa9abe23ad102c54615eebc007964fb053da
Diff: https://reviews.apache.org/r/25483/diff/
Testing (updated)
-------
./gradlew build -Pq
Thanks,
Zameer Manji
Re: Review Request 25483: Transaction all SQL under MemStorage
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25483/#review52790
-----------------------------------------------------------
src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java
<https://reviews.apache.org/r/25483/#comment91909>
after this, fail() (within the try block)
src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java
<https://reviews.apache.org/r/25483/#comment91908>
// Expected
src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java
<https://reviews.apache.org/r/25483/#comment91910>
assertEquals(ImmutableMap.<..>of(), fetchQuotas());
In this case it's not _that_ helpful, but this pattern results in generally more useful output from junit (expected vs actual).
- Bill Farner
On Sept. 9, 2014, 9:05 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25483/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2014, 9:05 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Bugs: AURORA-694
> https://issues.apache.org/jira/browse/AURORA-694
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This commit ensures all delegated tables are accessed via a transaction via MemStorage.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java d7d350ee85510e75804322ebf6a877e35bf8d0d3
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java a042fa9abe23ad102c54615eebc007964fb053da
>
> Diff: https://reviews.apache.org/r/25483/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 25483: Transaction all SQL under MemStorage
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25483/#review52798
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 9, 2014, 9:05 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25483/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2014, 9:05 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Bugs: AURORA-694
> https://issues.apache.org/jira/browse/AURORA-694
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This commit ensures all delegated tables are accessed via a transaction via MemStorage.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java d7d350ee85510e75804322ebf6a877e35bf8d0d3
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java a042fa9abe23ad102c54615eebc007964fb053da
>
> Diff: https://reviews.apache.org/r/25483/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 25483: Transaction all SQL under MemStorage
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25483/#review52797
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Sept. 9, 2014, 9:05 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25483/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2014, 9:05 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Bugs: AURORA-694
> https://issues.apache.org/jira/browse/AURORA-694
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This commit ensures all delegated tables are accessed via a transaction via MemStorage.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java d7d350ee85510e75804322ebf6a877e35bf8d0d3
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java a042fa9abe23ad102c54615eebc007964fb053da
>
> Diff: https://reviews.apache.org/r/25483/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>