You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/16 13:05:53 UTC

[GitHub] [spark] zero323 commented on a change in pull request #35546: [WIP][SPARK-37422][PYTHON][MLLIB] Inline typehints for pyspark.mllib.feature

zero323 commented on a change in pull request #35546:
URL: https://github.com/apache/spark/pull/35546#discussion_r807938421



##########
File path: python/pyspark/mllib/common.py
##########
@@ -127,13 +127,13 @@ def _java2py(sc: SparkContext, r: "JavaObjectOrPickleDump", encoding: str = "byt
 
 def callJavaFunc(
     sc: pyspark.context.SparkContext, func: Callable[..., "JavaObjectOrPickleDump"], *args: Any
-) -> "JavaObjectOrPickleDump":
+) -> Any:

Review comment:
       These turned out to be too restrictive.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org