You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/02/16 11:07:20 UTC
[GitHub] [incubator-pekko] mdedetrich opened a new pull request, #199: Add github PR check to make sure code is formatted
mdedetrich opened a new pull request, #199:
URL: https://github.com/apache/incubator-pekko/pull/199
Adds a github PR status check which disallows PR's from being merged if the code is not formatted. Note that its been verified that this works in another pekko module (see https://github.com/apache/incubator-pekko-sbt-paradox/blob/main/.asf.yaml#L28-L35)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jrudolph commented on pull request #199: Add github PR check to make sure code is formatted
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #199:
URL: https://github.com/apache/incubator-pekko/pull/199#issuecomment-1432989608
> I am slightly wary in adding other checks right now because if you aren't careful you can freeze the github project (i.e. disallow any PR's from being merged) and you have to make an INFRA ticket to unblock it. For other checks we should test it out properly by making a dummy branch (as was done with incubator-pekko-sbt-paradox). The other issue here is if the name of the check changes unintentionally then we can get into this state.
Yes, I agree, that would be unfortunate...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #199: Add github PR check to make sure code is formatted
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #199:
URL: https://github.com/apache/incubator-pekko/pull/199#issuecomment-1432922427
> In general, at least "Headers" and "Tests (pull_request)" should also be added.
I am slightly wary in adding other checks right now because if you aren't careful you can freeze the github project (i.e. disallow any PR's from being merged) and you have to make an INFRA ticket to block it. For other checks we should test it out properly by making a dummy branch (as was done with incubator-pekko-sbt-paradox). The other issue here is if the name of the check changes unintentionally then we can get into this state.
I am adding it for scalafmt now because that has close to zero change of ever needing to be changed and I am 100% sure it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich merged pull request #199: Add github PR check to make sure code is formatted
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #199:
URL: https://github.com/apache/incubator-pekko/pull/199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jrudolph commented on pull request #199: Add github PR check to make sure code is formatted
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #199:
URL: https://github.com/apache/incubator-pekko/pull/199#issuecomment-1432919091
In general, at least "Headers" and "Tests (pull_request)" should also be added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org