You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Barrie Treloar (JIRA)" <ji...@apache.org> on 2011/05/25 09:43:47 UTC

[jira] [Commented] (LANG-378) Add new ToStyle to support MultiLine with Indent

    [ https://issues.apache.org/jira/browse/LANG-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039003#comment-13039003 ] 

Barrie Treloar commented on LANG-378:
-------------------------------------

*WARNING*
The class as implemented is *NOT ThreadSafe*.

I forgot that ToStyles where meant to be singletons and there is state kept in this class (i.e. the singleton) for use when indenting/outdenting.
Obviously this isn't thread safe if two threads attempt to use this ToStyle on different objects at the same time.

> Add new ToStyle to support MultiLine with Indent
> ------------------------------------------------
>
>                 Key: LANG-378
>                 URL: https://issues.apache.org/jira/browse/LANG-378
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.builder.*
>    Affects Versions: 2.3
>            Reporter: Barrie Treloar
>            Priority: Minor
>             Fix For: 3.x
>
>         Attachments: LANG-378-patch.txt, MultiLineWithIndentToStyle.zip
>
>
> Multiline support  places everything on a new line with no indentation to help in readability.
> Attached is a patch (with tests) to support Multiline behaviour with indentation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira